[Fix][UI][V1.0.0-Beta] Remove the sql comment in the procedure task a…

…nd add the instructions link to the procedure task. (apache#9619)
fengjian1129 · Apr 23, 2022 · ce730e1 · ce730e1
1 parent 6dfa81c
commit ce730e1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/dolphinscheduler-ui-next/src/views/projects/task/components/node/detail-modal.tsx b/dolphinscheduler-ui-next/src/views/projects/task/components/node/detail-modal.tsx
@@ -119,11 +119,13 @@ const NodeDetailModal = defineComponent({
           text: t('project.node.instructions'),
           show: !!(taskType && !TASK_TYPES_MAP[taskType]?.helperLinkDisable),
           action: () => {
+            let linkedTaskType = taskType?.toLowerCase().replace('_', '-')
+            if (taskType === 'PROCEDURE') linkedTaskType = 'stored-procedure'
             const helpUrl =
               'https://dolphinscheduler.apache.org/' +
               locale.value.toLowerCase().replace('_', '-') +
               '/docs/latest/user_doc/guide/task/' +
-              taskType?.toLowerCase().replace('_', '-') +
+              linkedTaskType +
               '.html'
             window.open(helpUrl)
           },

diff --git a/dolphinscheduler-ui-next/src/views/projects/task/components/node/fields/use-procedure.ts b/dolphinscheduler-ui-next/src/views/projects/task/components/node/fields/use-procedure.ts
@@ -28,10 +28,7 @@ export function useProcedure(model: { [field: string]: any }): IJsonItem[] {
       name: t('project.node.procedure_method'),
       props: {
         language: 'sql',
-        placeholder: t('project.node.procedure_method_tips'),
-        defaultValue: model.method
-          ? model.method
-          : t('project.node.procedure_method_snippet')
+        placeholder: t('project.node.procedure_method_tips')
       },
       validate: {
         trigger: ['input', 'trigger'],

diff --git a/dolphinscheduler-ui-next/src/views/projects/task/constants/task-type.ts b/dolphinscheduler-ui-next/src/views/projects/task/constants/task-type.ts
@@ -42,8 +42,7 @@ export const TASK_TYPES_MAP = {
     alias: 'SUB_PROCESS'
   },
   PROCEDURE: {
-    alias: 'PROCEDURE',
-    helperLinkDisable: true
+    alias: 'PROCEDURE'
   },
   SQL: {
     alias: 'SQL'