-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[opt](nereids) let DBA ignore some runtime filters #25933
Conversation
run buildall |
run buildall |
(From new machine)TeamCity pipeline, clickbench performance test result: |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…26164) 1. FE could not compile because below error. Intro by PR #25933 ``` [INFO] --- exec:3.1.0:java (doc) @ fe-core --- ... Failed to generate doc for ignoreRuntimeFilterIds ``` 2. fix UT bugs intro by below PRs > - #25951 > - #26031 3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR #25933 merged. So this PR revert them to fix FE UT > - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (#26145)" > This reverts commit 8d7abf6. > - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (#26130)" > This reverts commit 19122b5. > - Revert "[Performance](Nereids): optimize GroupExpressionMatching (#26084)" > This reverts commit 0d956e9.
example: set ignore_runtime_filter_ids="3, 1"; after this setting, RF003 and RF001 will be ignored
example: set ignore_runtime_filter_ids="3, 1"; after this setting, RF003 and RF001 will be ignored
example: set ignore_runtime_filter_ids="3, 1"; after this setting, RF003 and RF001 will be ignored
…pache#26164) 1. FE could not compile because below error. Intro by PR apache#25933 ``` [INFO] --- exec:3.1.0:java (doc) @ fe-core --- ... Failed to generate doc for ignoreRuntimeFilterIds ``` 2. fix UT bugs intro by below PRs > - apache#25951 > - apache#26031 3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR apache#25933 merged. So this PR revert them to fix FE UT > - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (apache#26145)" > This reverts commit 8d7abf6. > - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (apache#26130)" > This reverts commit 19122b5. > - Revert "[Performance](Nereids): optimize GroupExpressionMatching (apache#26084)" > This reverts commit 0d956e9.
example: set ignore_runtime_filter_ids="3, 1"; after this setting, RF003 and RF001 will be ignored
…pache#26164) 1. FE could not compile because below error. Intro by PR apache#25933 ``` [INFO] --- exec:3.1.0:java (doc) @ fe-core --- ... Failed to generate doc for ignoreRuntimeFilterIds ``` 2. fix UT bugs intro by below PRs > - apache#25951 > - apache#26031 3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR apache#25933 merged. So this PR revert them to fix FE UT > - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (apache#26145)" > This reverts commit 8d7abf6. > - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (apache#26130)" > This reverts commit 19122b5. > - Revert "[Performance](Nereids): optimize GroupExpressionMatching (apache#26084)" > This reverts commit 0d956e9.
example: set ignore_runtime_filter_ids="3, 1"; after this setting, RF003 and RF001 will be ignored
…pache#26164) 1. FE could not compile because below error. Intro by PR apache#25933 ``` [INFO] --- exec:3.1.0:java (doc) @ fe-core --- ... Failed to generate doc for ignoreRuntimeFilterIds ``` 2. fix UT bugs intro by below PRs > - apache#25951 > - apache#26031 3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR apache#25933 merged. So this PR revert them to fix FE UT > - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (apache#26145)" > This reverts commit 8d7abf6. > - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (apache#26130)" > This reverts commit 19122b5. > - Revert "[Performance](Nereids): optimize GroupExpressionMatching (apache#26084)" > This reverts commit 0d956e9.
Proposed changes
example:
set ignore_runtime_filter_ids="3, 1";
after this setting, RF003 and RF001 will be ignored
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...