Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](compile) fe compile failed when generate doc and FE UT failed #26164

Merged
merged 7 commits into from
Nov 1, 2023
Merged

[fix](compile) fe compile failed when generate doc and FE UT failed #26164

merged 7 commits into from
Nov 1, 2023

Conversation

morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Oct 31, 2023 •
edited
Loading

  1. FE could not compile because below error. Intro by PR [opt](nereids) let DBA ignore some runtime filters #25933
[INFO] --- exec:3.1.0:java (doc) @ fe-core ---
...
Failed to generate doc for ignoreRuntimeFilterIds
  1. fix UT bugs intro by below PR
  1. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PR merged after PR [opt](nereids) let DBA ignore some runtime filters #25933 merged. So this PR revert them to fix FE UT

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow morrySnow requested a review from englefly October 31, 2023 08:33
englefly
englefly previously approved these changes Oct 31, 2023
View reviewed changes
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Oct 31, 2023
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 46.1 seconds
stream load tsv: 552 seconds loaded 74807831229 Bytes, about 129 MB/s
stream load json: 21 seconds loaded 2358488459 Bytes, about 107 MB/s
stream load orc: 64 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162001404 Bytes

morningman
morningman previously approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow
[fix](compile) fe compile failed when generate doc
2ad8c66 
error msg:
[INFO] --- exec:3.1.0:java (doc) @ fe-core ---
...
Failed to generate doc for ignoreRuntimeFilterIds
@morrySnow
Revert "[enhancement](Nereids): optimize GroupExpressionMatching (apa…
947ca3f 
…che#26130)"

This reverts commit 19122b5.
@morrySnow
Revert "Revert "[enhancement](Nereids): optimize GroupExpressionMatch…
b49ae4f 
…ing (apache#26130)""

This reverts commit 947ca3f.
@morrySnow
Revert "[enhancement](Nereids): optimize GroupExpressionMatching (apa…
fa163fc 
…che#26130)"

This reverts commit 19122b5.
@morrySnow
Revert "[Performance](Nereids): optimize GroupExpressionMatching (apa…
1a4fa54 
…che#26084)"

This reverts commit 0d956e9.
@morrySnow
Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate…
2215216 
… do not change plan when match ba… (apache#26145)"

This reverts commit 8d7abf6.
@morrySnow
[fix](Nereids) ut failed intro by PR apache#25951
60ba436
@morrySnow morrySnow dismissed stale reviews from morningman and englefly via 60ba436 October 31, 2023 13:31
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Oct 31, 2023
@morrySnow
Copy link
Contributor Author

run buildall

@morrySnow morrySnow changed the title [fix](compile) fe compile failed when generate doc [fix](compile) fe compile failed when generate doc and FE UT failed Oct 31, 2023
@doris-robot
Copy link

(From new machine)TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 45.59 seconds
stream load tsv: 570 seconds loaded 74807831229 Bytes, about 125 MB/s
stream load json: 20 seconds loaded 2358488459 Bytes, about 112 MB/s
stream load orc: 65 seconds loaded 1101869774 Bytes, about 16 MB/s
stream load parquet: 32 seconds loaded 861443392 Bytes, about 25 MB/s
insert into select: 29.0 seconds inserted 10000000 Rows, about 344K ops/s
storage size: 17162298859 Bytes

morningman
morningman approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 1, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2023

PR approved by at least one committer and no changes requested.

shuke987
shuke987 approved these changes Nov 1, 2023
View reviewed changes
Copy link
Collaborator

@shuke987 shuke987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrySnow morrySnow merged commit 18dabe7 into apache:master Nov 1, 2023
@morrySnow morrySnow deleted the fix_doc_gen branch November 1, 2023 01:50
dutyu pushed a commit to dutyu/doris that referenced this pull request Nov 4, 2023
@morrySnow
[fix](compile) fe compile failed when generate doc and FE UT failed (a…
0ee2870 
…pache#26164)

1. FE could not compile because below error. Intro by PR apache#25933
```
[INFO] --- exec:3.1.0:java (doc) @ fe-core ---
...
Failed to generate doc for ignoreRuntimeFilterIds
```

2. fix UT bugs intro by below PRs
> - apache#25951
> - apache#26031

3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR apache#25933 merged. So this PR revert them to fix FE UT

> - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (apache#26145)"
> This reverts commit 8d7abf6.

> - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (apache#26130)"
> This reverts commit 19122b5.

> - Revert "[Performance](Nereids): optimize GroupExpressionMatching (apache#26084)"
> This reverts commit 0d956e9.
seawinde pushed a commit to seawinde/doris that referenced this pull request Nov 13, 2023
@morrySnow @seawinde
[fix](compile) fe compile failed when generate doc and FE UT failed (a…
4677a82 
…pache#26164)

1. FE could not compile because below error. Intro by PR apache#25933
```
[INFO] --- exec:3.1.0:java (doc) @ fe-core ---
...
Failed to generate doc for ignoreRuntimeFilterIds
```

2. fix UT bugs intro by below PRs
> - apache#25951
> - apache#26031

3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR apache#25933 merged. So this PR revert them to fix FE UT

> - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (apache#26145)"
> This reverts commit 8d7abf6.

> - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (apache#26130)"
> This reverts commit 19122b5.

> - Revert "[Performance](Nereids): optimize GroupExpressionMatching (apache#26084)"
> This reverts commit 0d956e9.
XuJianxu pushed a commit to XuJianxu/doris that referenced this pull request Dec 14, 2023
@morrySnow
[fix](compile) fe compile failed when generate doc and FE UT failed (a…
ae8163e 
…pache#26164)

1. FE could not compile because below error. Intro by PR apache#25933
```
[INFO] --- exec:3.1.0:java (doc) @ fe-core ---
...
Failed to generate doc for ignoreRuntimeFilterIds
```

2. fix UT bugs intro by below PRs
> - apache#25951
> - apache#26031

3. because fe could not compile, FE UT CI do not work well. So, some UT failed be introduced by the PRs merged after PR apache#25933 merged. So this PR revert them to fix FE UT

> - Revert "[Bug](materialized-view) SelectMaterializedIndexWithAggregate do not change plan > when match ba… (apache#26145)"
> This reverts commit 8d7abf6.

> - Revert "[enhancement](Nereids): optimize GroupExpressionMatching (apache#26130)"
> This reverts commit 19122b5.

> - Revert "[Performance](Nereids): optimize GroupExpressionMatching (apache#26084)"
> This reverts commit 0d956e9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuke987 shuke987 shuke987 approved these changes

@morningman morningman morningman approved these changes

@englefly englefly englefly left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@morrySnow @doris-robot @englefly @morningman @shuke987