[opt](log) refine the BE logger #35942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 42269 ms |
TPC-DS: Total hot run time: 174027 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 31.11 s |
morningman
changed the title
|
PR approved by anyone and no changes requested. |
CalvinKirs
approved these changes
Jun 6, 2024
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
morningman
added a commit
to morningman/doris
that referenced
this pull request
Jun 6, 2024
Followup apache#35679 Previously, BE logs were written to files. The main FE logs include be.INFO, be.WARNING, be.out, be.gc.log and jni.log. In a K8s deployment environment, logs usually need to be output to standard output, and then other components process the log stream. This PR made the following changes: 1. Modified the glog config: - When started with `--daemon`, logs are still written to various files, and the format remains unchanged. - When started with `--console`, be.INFO's log is output to standard output and marked with prefix `RuntimeLogger`. Examples are as follows: ``` RuntimeLogger I20240605 23:41:20.426553 4137369 runtime_query_statistics_mgr.cpp:245] Report profile thread stopped ``` 2. Added a new BE config: `enable_file_logger` Defaults to true. Indicates that logs will be recorded to files regardless of the startup method. For example, if it is started with `--console`, the log will be output to both the file and the standard output. If it is `false`, the log will not be recorded in the file regardless of the startup method. - Need to handle jni.log in next PR
morningman
added a commit
that referenced
this pull request
Jun 6, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 7, 2024
Followup #35679 ## Background Previously, BE logs were written to files. The main FE logs include be.INFO, be.WARNING, be.out, be.gc.log and jni.log. In a K8s deployment environment, logs usually need to be output to standard output, and then other components process the log stream. ## Solution This PR made the following changes: 1. Modified the glog config: - When started with `--daemon`, logs are still written to various files, and the format remains unchanged. - When started with `--console`, be.INFO's log is output to standard output and marked with prefix `RuntimeLogger`. Examples are as follows: ``` RuntimeLogger I20240605 23:41:20.426553 4137369 runtime_query_statistics_mgr.cpp:245] Report profile thread stopped ``` 2. Added a new BE config: `enable_file_logger` Defaults to true. Indicates that logs will be recorded to files regardless of the startup method. For example, if it is started with `--console`, the log will be output to both the file and the standard output. If it is `false`, the log will not be recorded in the file regardless of the startup method. ## TODO - Need to handle jni.log in next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup #35679
Background
Previously, BE logs were written to files. The main FE logs include be.INFO, be.WARNING, be.out, be.gc.log and jni.log.
In a K8s deployment environment, logs usually need to be output to standard output, and then other components process the log stream.
Solution
This PR made the following changes:
Modified the glog config:
When started with
--daemon, logs are still written to various files, and the format remains unchanged.When started with
--console, be.INFO's log is output to standard output and marked with prefixRuntimeLogger.Examples are as follows:
Added a new BE config:
enable_file_loggerDefaults to true. Indicates that logs will be recorded to files regardless of the startup method. For example, if it is started with
--console, the log will be output to both the file and the standard output. If it isfalse, the log will not be recorded in the file regardless of the startup method.TODO