Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opt](log) refine the BE logger (#35942) #35988

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

morningman
Copy link
Contributor

bp #35942

Followup apache#35679

Previously, BE logs were written to files. The main FE logs include
be.INFO, be.WARNING, be.out, be.gc.log and jni.log.
In a K8s deployment environment, logs usually need to be output to
standard output, and then other components process the log stream.

This PR made the following changes:

1. Modified the glog config:

- When started with `--daemon`, logs are still written to various files,
and the format remains unchanged.
- When started with `--console`, be.INFO's log is output to standard
output and marked with prefix `RuntimeLogger`.

		Examples are as follows:

		```
RuntimeLogger I20240605 23:41:20.426553 4137369
runtime_query_statistics_mgr.cpp:245] Report profile thread stopped
		```

2. Added a new BE config: `enable_file_logger`

Defaults to true. Indicates that logs will be recorded to files
regardless of the startup method. For example, if it is started with
`--console`, the log will be output to both the file and the standard
output. If it is `false`, the log will not be recorded in the file
regardless of the startup method.

- Need to handle jni.log in next PR
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morningman
Copy link
Contributor Author

run buildall

Copy link
Contributor

github-actions bot commented Jun 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@morningman morningman merged commit fbc82e0 into apache:branch-2.1 Jun 6, 2024
17 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants