Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](cloud) fix strict mode invalidation when copy.use_delete_sign is true for copy into #37650

Merged
merged 1 commit into from
Jul 13, 2024
Merged

[fix](cloud) fix strict mode invalidation when copy.use_delete_sign is true for copy into #37650

merged 1 commit into from
Jul 13, 2024

Conversation

sollhui
Copy link
Contributor

@sollhui sollhui commented Jul 11, 2024

Fix strict mode invalidation when copy.use_delete_sign is true for copy into

@sollhui @liaoxin01
fix strict mode invalidation when copy.use_delete_sign is true for co…
a651a62 
…py into

Co-authored-by: Xin Liao <liaoxinbit@126.com>
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@sollhui
Copy link
Contributor Author

sollhui commented Jul 11, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40166 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a651a627cf8ed0997220c89c324d34a219a78134, data reload: false

------ Round 1 ----------------------------------
q1	18046	4439	4410	4410
q2	2605	197	190	190
q3	11611	1194	1054	1054
q4	10360	810	783	783
q5	7830	2726	2734	2726
q6	226	146	144	144
q7	970	627	629	627
q8	9443	2071	2108	2071
q9	8899	6516	6537	6516
q10	8613	3775	3808	3775
q11	453	248	241	241
q12	406	254	233	233
q13	17747	2994	2985	2985
q14	284	252	250	250
q15	525	481	478	478
q16	455	376	383	376
q17	972	619	765	619
q18	8112	7433	7509	7433
q19	1714	1529	1425	1425
q20	658	322	322	322
q21	4974	3261	3168	3168
q22	412	344	340	340
Total cold run time: 115315 ms
Total hot run time: 40166 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4516	4299	4247	4247
q2	372	283	268	268
q3	2981	2764	2770	2764
q4	1868	1665	1612	1612
q5	5268	5301	5336	5301
q6	223	137	138	137
q7	2133	1773	1736	1736
q8	3247	3315	3332	3315
q9	8436	8413	8387	8387
q10	3906	3821	3786	3786
q11	607	497	486	486
q12	835	628	610	610
q13	17218	2999	3005	2999
q14	295	267	269	267
q15	517	474	478	474
q16	470	418	437	418
q17	1768	1480	1484	1480
q18	7720	7576	7344	7344
q19	1699	1424	1578	1424
q20	1981	1789	1751	1751
q21	4861	4748	4719	4719
q22	597	562	566	562
Total cold run time: 71518 ms
Total hot run time: 54087 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174648 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a651a627cf8ed0997220c89c324d34a219a78134, data reload: false

query1	925	371	366	366
query2	6457	2443	2470	2443
query3	6664	208	216	208
query4	24554	17570	17184	17184
query5	4251	485	479	479
query6	287	193	164	164
query7	4578	286	298	286
query8	336	310	305	305
query9	8378	2433	2424	2424
query10	448	290	274	274
query11	11390	10093	10381	10093
query12	150	106	84	84
query13	1647	367	361	361
query14	10086	7646	7697	7646
query15	243	185	191	185
query16	7809	316	321	316
query17	1805	553	528	528
query18	1955	291	271	271
query19	204	150	151	150
query20	89	79	84	79
query21	203	124	121	121
query22	4490	4014	3950	3950
query23	33729	33131	33212	33131
query24	11949	2929	2860	2860
query25	667	364	378	364
query26	1824	149	146	146
query27	2941	268	272	268
query28	7451	2086	2086	2086
query29	1145	605	600	600
query30	274	146	150	146
query31	962	746	751	746
query32	95	52	56	52
query33	773	296	299	296
query34	952	487	506	487
query35	677	565	585	565
query36	1098	963	954	954
query37	205	79	81	79
query38	2875	2753	2749	2749
query39	842	794	814	794
query40	284	119	117	117
query41	53	52	50	50
query42	121	98	99	98
query43	595	574	553	553
query44	1247	735	729	729
query45	195	171	170	170
query46	1093	725	736	725
query47	1895	1812	1783	1783
query48	360	294	307	294
query49	1198	429	413	413
query50	766	400	397	397
query51	6899	6747	6741	6741
query52	103	92	91	91
query53	354	291	286	286
query54	915	447	442	442
query55	73	74	76	74
query56	290	271	268	268
query57	1148	1038	1056	1038
query58	257	239	243	239
query59	3599	3335	3085	3085
query60	306	275	281	275
query61	98	99	140	99
query62	829	629	654	629
query63	323	303	288	288
query64	10480	2228	7481	2228
query65	3216	3102	3109	3102
query66	1374	335	343	335
query67	15480	14950	14944	14944
query68	4611	550	549	549
query69	485	326	364	326
query70	1183	1167	1168	1167
query71	395	282	277	277
query72	7156	5596	5645	5596
query73	740	326	329	326
query74	6110	5579	5593	5579
query75	3422	2689	2680	2680
query76	2557	951	944	944
query77	473	304	309	304
query78	10497	8957	10676	8957
query79	3100	541	539	539
query80	1638	469	470	469
query81	585	221	224	221
query82	720	131	135	131
query83	285	165	174	165
query84	263	91	85	85
query85	1606	332	306	306
query86	476	314	335	314
query87	3302	3147	3155	3147
query88	3731	2405	2361	2361
query89	469	394	381	381
query90	1862	195	200	195
query91	132	101	103	101
query92	69	49	50	49
query93	1484	513	508	508
query94	1323	209	212	209
query95	406	307	323	307
query96	595	276	278	276
query97	3180	3006	3025	3006
query98	215	199	205	199
query99	1573	1265	1241	1241
Total cold run time: 283602 ms
Total hot run time: 174648 ms

liaoxin01
liaoxin01 approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 11, 2024
@doris-robot
Copy link

ClickBench: Total hot run time: 30.59 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a651a627cf8ed0997220c89c324d34a219a78134, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.72	0.07	0.07
query5	0.50	0.49	0.50
query6	1.13	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.04
query9	0.55	0.48	0.47
query10	0.54	0.55	0.54
query11	0.15	0.10	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.58
query14	0.76	0.75	0.78
query15	0.85	0.80	0.81
query16	0.36	0.37	0.37
query17	0.95	0.97	0.97
query18	0.23	0.21	0.21
query19	1.79	1.71	1.75
query20	0.02	0.01	0.01
query21	15.41	0.75	0.66
query22	4.24	7.10	2.03
query23	18.34	1.33	1.26
query24	2.10	0.22	0.24
query25	0.16	0.08	0.09
query26	0.30	0.22	0.22
query27	0.46	0.23	0.23
query28	13.25	1.00	1.00
query29	12.60	3.27	3.26
query30	0.25	0.06	0.05
query31	2.90	0.39	0.39
query32	3.28	0.49	0.47
query33	2.91	2.86	2.96
query34	17.16	4.36	4.32
query35	4.40	4.43	4.52
query36	0.65	0.46	0.49
query37	0.19	0.17	0.15
query38	0.15	0.15	0.16
query39	0.04	0.03	0.03
query40	0.16	0.13	0.12
query41	0.09	0.05	0.04
query42	0.05	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 109.83 s
Total hot run time: 30.59 s

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01 liaoxin01 merged commit 5aee624 into apache:master Jul 13, 2024
27 of 30 checks passed
@sollhui sollhui deleted the cloud_copy_into_delete_sign branch July 15, 2024 03:59
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
@sollhui @liaoxin01 @seawinde
[fix](cloud) fix strict mode invalidation when copy.use_delete_sign i…
dfff4f1 
…s true for copy into (apache#37650)

Fix strict mode invalidation when copy.use_delete_sign is true for copy
into

Co-authored-by: Xin Liao <liaoxinbit@126.com>
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@sollhui @liaoxin01 @dataroaring
[fix](cloud) fix strict mode invalidation when copy.use_delete_sign i…
b3410bb 
…s true for copy into (#37650)

Fix strict mode invalidation when copy.use_delete_sign is true for copy
into

Co-authored-by: Xin Liao <liaoxinbit@126.com>
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@liaoxin01 liaoxin01 liaoxin01 approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sollhui @doris-robot @liaoxin01 @dataroaring