Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](cloud) fix strict mode invalidation when copy.use_delete_sign is true for copy into #37650

Merged
merged 1 commit into from
Jul 13, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -147,10 +147,16 @@ public void analyze(String fullDbName, TableName tableName, boolean useDeleteSig
}
} else {
for (int i = 0; i < targetColumns.size(); i++) {
BinaryPredicate binaryPredicate = new BinaryPredicate(Operator.EQ,
new SlotRef(null, targetColumns.get(i)),
new SlotRef(null, fileColumns.get(i)));
columnMappingList.add(binaryPredicate);
// If file column name equals target column name, don't need to add to
// columnMapping List. Otherwise it will result in invalidation of strict
// mode. Because if the src data is an expr, strict mode judgment will
// not be performed.
if (!fileColumns.get(i).equalsIgnoreCase(targetColumns.get(i))) {
BinaryPredicate binaryPredicate = new BinaryPredicate(Operator.EQ,
new SlotRef(null, targetColumns.get(i)),
new SlotRef(null, fileColumns.get(i)));
columnMappingList.add(binaryPredicate);
}
}
}
}
Expand Down
Loading