Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](delete) Incorrect precision detection for the decimal type in condition.​ #37801

Merged
merged 1 commit into from
Jul 16, 2024
Merged

[fix](delete) Incorrect precision detection for the decimal type in condition.​ #37801

merged 1 commit into from
Jul 16, 2024

Conversation

mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Jul 15, 2024

Proposed changes

For precision like Decimal(7,7), the value "0.1234567" should be valid(the integer part is 0).

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 15, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40235 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a765d1e02f1c366cab72f25b0e45954db2b7f9c6, data reload: false

------ Round 1 ----------------------------------
q1	18391	4437	4396	4396
q2	2587	199	196	196
q3	10965	1235	1156	1156
q4	10384	734	804	734
q5	8104	2717	2727	2717
q6	226	143	141	141
q7	982	622	627	622
q8	9243	2061	2064	2061
q9	8960	6563	6606	6563
q10	8757	3757	3789	3757
q11	453	247	249	247
q12	387	232	231	231
q13	17768	3017	2994	2994
q14	280	251	240	240
q15	524	467	471	467
q16	469	389	392	389
q17	971	653	659	653
q18	7995	7460	7438	7438
q19	5422	1323	1384	1323
q20	680	326	337	326
q21	5077	3306	3994	3306
q22	363	278	286	278
Total cold run time: 118988 ms
Total hot run time: 40235 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4399	4214	4219	4214
q2	367	300	259	259
q3	2976	2771	2781	2771
q4	1873	1618	1597	1597
q5	5305	5344	5309	5309
q6	221	129	133	129
q7	2162	1733	1746	1733
q8	3200	3301	3286	3286
q9	8414	8412	8464	8412
q10	3881	3656	3700	3656
q11	587	516	489	489
q12	803	623	598	598
q13	17540	2982	2988	2982
q14	304	289	268	268
q15	505	486	472	472
q16	471	438	454	438
q17	1765	1478	1476	1476
q18	7716	7519	7506	7506
q19	1689	1540	1565	1540
q20	2004	1761	1818	1761
q21	4995	4616	4737	4616
q22	597	516	514	514
Total cold run time: 71774 ms
Total hot run time: 54026 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172159 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a765d1e02f1c366cab72f25b0e45954db2b7f9c6, data reload: false

query1	908	370	360	360
query2	6460	1830	1742	1742
query3	6672	209	218	209
query4	24729	17168	17444	17168
query5	4195	484	499	484
query6	263	176	157	157
query7	4593	283	286	283
query8	238	189	192	189
query9	8441	2356	2357	2356
query10	443	299	275	275
query11	11676	9942	10177	9942
query12	134	86	84	84
query13	1636	384	384	384
query14	10323	7506	7440	7440
query15	213	168	169	168
query16	7748	321	333	321
query17	1415	530	517	517
query18	1843	280	280	280
query19	194	150	175	150
query20	92	81	84	81
query21	208	135	130	130
query22	4284	4049	4032	4032
query23	33744	33203	33092	33092
query24	12277	2843	2840	2840
query25	663	354	370	354
query26	1786	146	149	146
query27	2926	271	265	265
query28	7284	1971	1984	1971
query29	1096	626	606	606
query30	291	152	146	146
query31	962	714	753	714
query32	94	55	56	55
query33	766	313	285	285
query34	941	481	488	481
query35	718	577	553	553
query36	1147	951	954	951
query37	255	84	80	80
query38	2854	2742	2754	2742
query39	861	814	825	814
query40	275	123	124	123
query41	47	48	45	45
query42	127	98	103	98
query43	494	465	462	462
query44	1216	753	737	737
query45	190	162	158	158
query46	1084	751	701	701
query47	1831	1777	1766	1766
query48	378	292	297	292
query49	1183	463	416	416
query50	780	393	414	393
query51	6855	6833	6923	6833
query52	107	90	94	90
query53	361	284	291	284
query54	969	456	451	451
query55	74	73	76	73
query56	292	266	281	266
query57	1170	1056	1087	1056
query58	245	246	268	246
query59	2952	2782	2623	2623
query60	312	281	287	281
query61	98	96	93	93
query62	858	663	648	648
query63	330	294	289	289
query64	10540	2271	1700	1700
query65	3181	3137	3121	3121
query66	1356	339	333	333
query67	15559	15027	14906	14906
query68	4632	538	530	530
query69	464	328	345	328
query70	1199	1164	1113	1113
query71	392	287	283	283
query72	7203	5534	5878	5534
query73	751	377	321	321
query74	6060	5614	5662	5614
query75	3449	2679	2640	2640
query76	2751	960	918	918
query77	454	313	302	302
query78	9561	9254	8923	8923
query79	2448	516	507	507
query80	1973	496	498	496
query81	573	224	222	222
query82	804	150	140	140
query83	283	177	173	173
query84	282	91	89	89
query85	2071	317	295	295
query86	486	316	298	298
query87	3277	3165	3120	3120
query88	4035	2449	2471	2449
query89	497	406	384	384
query90	1869	203	202	202
query91	142	119	111	111
query92	70	53	54	53
query93	2470	498	503	498
query94	1286	228	227	227
query95	412	334	321	321
query96	604	275	277	275
query97	3162	3044	2985	2985
query98	229	280	194	194
query99	1715	1298	1283	1283
Total cold run time: 283841 ms
Total hot run time: 172159 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a765d1e02f1c366cab72f25b0e45954db2b7f9c6, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.04
query3	0.22	0.05	0.05
query4	1.68	0.06	0.07
query5	0.50	0.48	0.49
query6	1.14	0.72	0.73
query7	0.02	0.01	0.02
query8	0.05	0.05	0.04
query9	0.56	0.49	0.48
query10	0.54	0.54	0.54
query11	0.15	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.59	0.59
query14	0.75	0.78	0.83
query15	0.85	0.84	0.82
query16	0.37	0.36	0.37
query17	0.98	0.96	1.02
query18	0.23	0.22	0.21
query19	1.80	1.76	1.76
query20	0.01	0.00	0.01
query21	15.42	0.79	0.66
query22	3.79	7.30	2.43
query23	18.34	1.35	1.30
query24	2.09	0.22	0.22
query25	0.16	0.08	0.08
query26	0.30	0.21	0.22
query27	0.45	0.22	0.22
query28	13.34	1.02	0.99
query29	12.64	3.41	3.37
query30	0.26	0.06	0.06
query31	2.88	0.40	0.38
query32	3.28	0.47	0.47
query33	2.88	2.92	2.90
query34	17.19	4.36	4.46
query35	4.46	4.46	4.42
query36	0.66	0.46	0.48
query37	0.20	0.18	0.17
query38	0.15	0.16	0.14
query39	0.05	0.04	0.03
query40	0.15	0.12	0.13
query41	0.08	0.04	0.05
query42	0.06	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.59 s
Total hot run time: 31.27 s

@mrhhsg mrhhsg force-pushed the fix_delete_decimal branch from a765d1e to 5b20d5c Compare July 15, 2024 14:05
@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 15, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 39973 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5b20d5c576f1b356cb26a87aa0fb5acb5920ebef, data reload: false

------ Round 1 ----------------------------------
q1	17618	4349	4298	4298
q2	2021	192	189	189
q3	10463	1295	1142	1142
q4	10191	873	774	774
q5	7649	2721	2664	2664
q6	220	138	152	138
q7	1025	637	618	618
q8	9220	2070	2110	2070
q9	8709	6526	6523	6523
q10	8843	3824	3736	3736
q11	478	240	241	240
q12	452	224	227	224
q13	18862	2997	3038	2997
q14	273	240	234	234
q15	522	484	469	469
q16	515	375	377	375
q17	974	674	685	674
q18	8178	7613	7377	7377
q19	7431	1554	1427	1427
q20	693	326	341	326
q21	4937	3195	3204	3195
q22	348	286	283	283
Total cold run time: 119622 ms
Total hot run time: 39973 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4433	4284	4310	4284
q2	373	275	266	266
q3	3120	2910	2978	2910
q4	1996	1815	1778	1778
q5	5631	5592	5537	5537
q6	234	134	140	134
q7	2264	1860	1840	1840
q8	3308	3432	3430	3430
q9	8858	8949	8780	8780
q10	4067	3727	3831	3727
q11	612	501	506	501
q12	817	638	644	638
q13	16287	3174	3250	3174
q14	314	279	310	279
q15	520	496	490	490
q16	503	439	444	439
q17	1825	1531	1521	1521
q18	8154	7948	8009	7948
q19	1756	1642	1488	1488
q20	2837	1870	1848	1848
q21	10653	4857	4693	4693
q22	613	508	515	508
Total cold run time: 79175 ms
Total hot run time: 56213 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 174280 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5b20d5c576f1b356cb26a87aa0fb5acb5920ebef, data reload: false

query1	925	372	371	371
query2	6458	1813	1792	1792
query3	6644	205	222	205
query4	28420	17534	17593	17534
query5	3767	501	494	494
query6	280	173	171	171
query7	4581	304	295	295
query8	252	202	201	201
query9	8633	2432	2424	2424
query10	451	294	280	280
query11	10149	10123	10102	10102
query12	115	83	90	83
query13	1633	375	384	375
query14	10289	7849	7737	7737
query15	261	179	174	174
query16	7151	324	312	312
query17	1797	539	526	526
query18	1191	281	285	281
query19	198	143	151	143
query20	90	79	80	79
query21	198	125	121	121
query22	4219	4005	4097	4005
query23	34072	33650	33566	33566
query24	10735	2930	2862	2862
query25	621	394	393	393
query26	714	157	155	155
query27	2323	293	289	289
query28	5969	2107	2099	2099
query29	916	642	652	642
query30	263	155	155	155
query31	971	789	748	748
query32	98	54	54	54
query33	647	305	302	302
query34	895	510	513	510
query35	697	590	624	590
query36	1165	931	983	931
query37	150	86	82	82
query38	2938	2850	2766	2766
query39	917	818	833	818
query40	210	119	117	117
query41	50	44	48	44
query42	121	96	103	96
query43	501	459	465	459
query44	1117	736	742	736
query45	187	157	159	157
query46	1095	737	737	737
query47	1865	1766	1775	1766
query48	385	300	296	296
query49	826	411	420	411
query50	777	392	392	392
query51	7070	6730	6841	6730
query52	106	97	95	95
query53	360	281	289	281
query54	865	460	449	449
query55	74	73	73	73
query56	294	270	275	270
query57	1105	1052	1081	1052
query58	247	271	252	252
query59	2796	2605	2649	2605
query60	294	280	282	280
query61	101	95	95	95
query62	815	667	633	633
query63	317	291	299	291
query64	9160	2284	1670	1670
query65	3157	3121	3130	3121
query66	740	333	330	330
query67	15571	15091	14924	14924
query68	4491	554	563	554
query69	558	488	364	364
query70	1191	1154	1153	1153
query71	399	289	287	287
query72	7010	5949	5481	5481
query73	765	330	330	330
query74	6142	5663	5704	5663
query75	3406	2732	2721	2721
query76	2119	976	951	951
query77	477	309	307	307
query78	9689	9328	9138	9138
query79	2674	550	538	538
query80	1896	508	491	491
query81	588	221	219	219
query82	826	146	138	138
query83	287	170	169	169
query84	275	88	90	88
query85	1772	325	300	300
query86	475	335	335	335
query87	3284	3073	3116	3073
query88	4611	2383	2389	2383
query89	499	383	391	383
query90	1770	200	198	198
query91	128	98	101	98
query92	59	50	49	49
query93	4640	536	520	520
query94	1110	218	216	216
query95	405	318	315	315
query96	635	274	270	270
query97	3211	3057	3042	3042
query98	224	199	201	199
query99	1599	1278	1284	1278
Total cold run time: 279214 ms
Total hot run time: 174280 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 31.22 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5b20d5c576f1b356cb26a87aa0fb5acb5920ebef, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.06
query4	1.67	0.09	0.09
query5	0.51	0.50	0.50
query6	1.13	0.76	0.73
query7	0.02	0.02	0.01
query8	0.06	0.05	0.04
query9	0.55	0.48	0.48
query10	0.53	0.54	0.53
query11	0.15	0.11	0.11
query12	0.15	0.13	0.12
query13	0.59	0.58	0.58
query14	0.76	0.78	0.78
query15	0.85	0.82	0.82
query16	0.36	0.35	0.37
query17	0.96	1.03	1.03
query18	0.23	0.22	0.22
query19	1.86	1.70	1.73
query20	0.01	0.01	0.01
query21	15.40	0.75	0.66
query22	4.52	6.67	2.34
query23	18.30	1.32	1.29
query24	2.08	0.22	0.24
query25	0.15	0.09	0.08
query26	0.31	0.22	0.21
query27	0.45	0.24	0.23
query28	13.22	1.04	1.01
query29	12.64	3.39	3.33
query30	0.25	0.06	0.06
query31	2.87	0.39	0.39
query32	3.26	0.50	0.49
query33	2.88	2.87	2.92
query34	16.91	4.40	4.35
query35	4.49	4.47	4.40
query36	0.65	0.48	0.49
query37	0.19	0.15	0.16
query38	0.16	0.15	0.15
query39	0.04	0.03	0.03
query40	0.16	0.12	0.12
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.05	0.04
Total cold run time: 109.85 s
Total hot run time: 31.22 s

@mrhhsg mrhhsg force-pushed the fix_delete_decimal branch from 5b20d5c to a465f31 Compare July 16, 2024 01:45
@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 16, 2024

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@yiguolei
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39607 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a465f31ab94c75ac939dfdd15733f22f25281de4, data reload: false

------ Round 1 ----------------------------------
q1	17603	4352	4309	4309
q2	2017	201	180	180
q3	10449	1141	997	997
q4	10190	820	800	800
q5	7522	2706	2656	2656
q6	220	138	135	135
q7	957	603	595	595
q8	9214	2050	2079	2050
q9	8719	6564	6565	6564
q10	8793	3793	3755	3755
q11	457	233	238	233
q12	429	221	226	221
q13	17771	2967	2978	2967
q14	279	240	232	232
q15	509	498	486	486
q16	509	390	379	379
q17	949	600	649	600
q18	7963	7510	7325	7325
q19	3339	1347	1398	1347
q20	682	324	311	311
q21	4987	3187	3307	3187
q22	361	279	278	278
Total cold run time: 113919 ms
Total hot run time: 39607 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4411	4248	4281	4248
q2	373	278	266	266
q3	3004	2750	2817	2750
q4	1993	1658	1691	1658
q5	5557	5631	5539	5539
q6	218	130	134	130
q7	2245	1786	1829	1786
q8	3300	3419	3404	3404
q9	8756	8783	8833	8783
q10	4169	3808	3922	3808
q11	585	499	494	494
q12	785	614	614	614
q13	16185	3233	3203	3203
q14	327	295	295	295
q15	527	504	483	483
q16	498	430	451	430
q17	1786	1512	1506	1506
q18	8110	8176	7870	7870
q19	1708	1587	1685	1587
q20	2129	1914	1874	1874
q21	9841	4905	5050	4905
q22	579	507	488	488
Total cold run time: 77086 ms
Total hot run time: 56121 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 175242 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a465f31ab94c75ac939dfdd15733f22f25281de4, data reload: false

query1	905	371	362	362
query2	6448	1878	1842	1842
query3	6639	213	220	213
query4	26039	17641	17412	17412
query5	3667	474	495	474
query6	259	167	178	167
query7	4581	290	290	290
query8	237	198	202	198
query9	8775	2433	2399	2399
query10	444	300	278	278
query11	11203	10213	10229	10213
query12	118	91	88	88
query13	1660	362	372	362
query14	10417	7910	7702	7702
query15	224	168	179	168
query16	7759	320	329	320
query17	1783	560	544	544
query18	1874	296	281	281
query19	201	157	156	156
query20	98	84	86	84
query21	205	134	127	127
query22	4379	4277	4078	4078
query23	34148	33594	33657	33594
query24	10729	2938	3045	2938
query25	615	433	417	417
query26	702	162	158	158
query27	2200	283	284	283
query28	6303	2120	2098	2098
query29	919	677	649	649
query30	261	161	157	157
query31	1017	756	756	756
query32	100	59	56	56
query33	684	321	308	308
query34	898	510	502	502
query35	684	603	610	603
query36	1115	945	996	945
query37	149	83	91	83
query38	3004	2886	2908	2886
query39	900	885	846	846
query40	216	131	130	130
query41	49	47	46	46
query42	113	101	98	98
query43	527	463	461	461
query44	1143	739	733	733
query45	195	166	171	166
query46	1124	731	744	731
query47	1861	1815	1816	1815
query48	379	290	296	290
query49	838	522	406	406
query50	778	393	383	383
query51	6843	6774	6724	6724
query52	118	90	97	90
query53	364	292	288	288
query54	900	444	456	444
query55	76	74	75	74
query56	279	263	273	263
query57	1120	1054	1073	1054
query58	234	246	251	246
query59	3024	2612	2533	2533
query60	293	274	275	274
query61	96	94	96	94
query62	804	657	650	650
query63	321	288	283	283
query64	9141	2223	7473	2223
query65	3142	3107	3109	3107
query66	760	330	323	323
query67	15785	15133	14903	14903
query68	8678	569	570	569
query69	765	463	353	353
query70	1388	1162	1104	1104
query71	533	276	271	271
query72	9000	5550	5612	5550
query73	1701	338	328	328
query74	6207	5697	5913	5697
query75	5387	2766	2741	2741
query76	5233	957	970	957
query77	789	306	309	306
query78	10571	9258	9919	9258
query79	9966	533	525	525
query80	958	485	472	472
query81	574	231	223	223
query82	289	134	132	132
query83	330	171	164	164
query84	274	129	86	86
query85	883	313	299	299
query86	358	311	316	311
query87	3412	3117	3152	3117
query88	4758	2385	2382	2382
query89	487	381	377	377
query90	2096	200	198	198
query91	132	101	103	101
query92	62	53	51	51
query93	4384	521	517	517
query94	1398	213	214	213
query95	416	317	315	315
query96	614	313	269	269
query97	3201	3047	3036	3036
query98	219	205	199	199
query99	1511	1259	1252	1252
Total cold run time: 299440 ms
Total hot run time: 175242 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.41 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a465f31ab94c75ac939dfdd15733f22f25281de4, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.22	0.04	0.05
query4	1.68	0.06	0.07
query5	0.50	0.48	0.48
query6	1.14	0.72	0.73
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.54	0.50	0.48
query10	0.54	0.56	0.55
query11	0.15	0.11	0.11
query12	0.14	0.12	0.12
query13	0.60	0.58	0.58
query14	0.78	0.78	0.77
query15	0.86	0.82	0.81
query16	0.37	0.38	0.34
query17	0.95	0.95	0.98
query18	0.23	0.22	0.21
query19	1.80	1.70	1.76
query20	0.01	0.02	0.01
query21	15.44	0.73	0.65
query22	4.15	7.66	1.85
query23	18.28	1.29	1.17
query24	2.15	0.22	0.23
query25	0.15	0.09	0.08
query26	0.29	0.21	0.20
query27	0.46	0.23	0.23
query28	13.18	1.01	1.00
query29	12.64	3.27	3.26
query30	0.25	0.06	0.05
query31	2.88	0.40	0.39
query32	3.27	0.49	0.48
query33	2.92	2.91	2.88
query34	17.03	4.37	4.45
query35	4.47	4.47	4.56
query36	0.65	0.47	0.47
query37	0.20	0.15	0.16
query38	0.16	0.14	0.15
query39	0.04	0.03	0.03
query40	0.15	0.13	0.14
query41	0.09	0.05	0.05
query42	0.06	0.05	0.06
query43	0.05	0.04	0.04
Total cold run time: 109.65 s
Total hot run time: 30.41 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit cd6f568 into apache:master Jul 16, 2024
27 of 31 checks passed
@mrhhsg mrhhsg deleted the fix_delete_decimal branch July 16, 2024 07:44
mrhhsg added a commit to mrhhsg/doris that referenced this pull request Jul 16, 2024
@mrhhsg
[fix](delete) Incorrect precision detection for the decimal type in c…
5230723 
…ondition.​ (apache#37801)

## Proposed changes

For precision like Decimal(7,7), the value "0.1234567" should be
valid(the integer part is 0).
@mrhhsg mrhhsg mentioned this pull request Jul 16, 2024
Merged
yiguolei pushed a commit that referenced this pull request Jul 16, 2024
@mrhhsg
[fix](delete) Incorrect precision detection for the decimal type in c…
8440303 
…ondition.​ (#37801) (#37904)

## Proposed changes

pick #37801

For precision like Decimal(7,7), the value "0.1234567" should be
valid(the integer part is 0).

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->
seawinde pushed a commit to seawinde/doris that referenced this pull request Jul 17, 2024
@mrhhsg @seawinde
[fix](delete) Incorrect precision detection for the decimal type in c…
2ebb0c8 
…ondition.​ (apache#37801)

## Proposed changes

For precision like Decimal(7,7), the value "0.1234567" should be
valid(the integer part is 0).
dataroaring pushed a commit that referenced this pull request Jul 17, 2024
@mrhhsg @dataroaring
[fix](delete) Incorrect precision detection for the decimal type in c…
22600b4 
…ondition.​ (#37801)

## Proposed changes

For precision like Decimal(7,7), the value "0.1234567" should be
valid(the integer part is 0).
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
Open
1 task
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gabriel39 Gabriel39 Gabriel39 approved these changes

@jacktengg jacktengg jacktengg approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mrhhsg @doris-robot @yiguolei @jacktengg @Gabriel39 @dataroaring