Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](delete) Incorrect precision detection for the decimal type in condition.​ (#37801) #37904

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Jul 16, 2024

Proposed changes

pick #37801

For precision like Decimal(7,7), the value "0.1234567" should be valid(the integer part is 0).

Proposed changes

Issue Number: close #xxx

…ondition.​ (apache#37801)

## Proposed changes

For precision like Decimal(7,7), the value "0.1234567" should be
valid(the integer part is 0).
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 16, 2024

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.44% (9239/25351)
Line Coverage: 28.00% (75537/269800)
Region Coverage: 26.83% (38839/144784)
Branch Coverage: 23.57% (19721/83686)
Coverage Report: http://coverage.selectdb-in.cc/coverage/523072361f1bdff00fbec179773e25a4dd2fddad_523072361f1bdff00fbec179773e25a4dd2fddad/report/index.html

@yiguolei yiguolei merged commit 8440303 into apache:branch-2.1 Jul 16, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants