Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config](be) add be config migration_lock_timeout_ms #38000

Merged
merged 1 commit into from
Jul 18, 2024
Merged

[config](be) add be config migration_lock_timeout_ms #38000

merged 1 commit into from
Jul 18, 2024

Conversation

kaijchen
Copy link
Contributor

Proposed changes

Add be config migration_lock_timeout_ms and increase default value from 30ms to 1000ms.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaijchen
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

dataroaring
dataroaring approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 39982 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 367c679f2bf824ddb59c91f6de06d34ee39e66bd, data reload: false

------ Round 1 ----------------------------------
q1	17624	4957	4288	4288
q2	2006	188	189	188
q3	10457	1161	1051	1051
q4	10180	844	857	844
q5	7554	2728	2667	2667
q6	217	133	138	133
q7	961	594	585	585
q8	9202	2077	2096	2077
q9	8713	6570	6594	6570
q10	8690	3801	3749	3749
q11	460	230	234	230
q12	389	217	216	216
q13	17773	2972	2940	2940
q14	266	230	230	230
q15	521	461	468	461
q16	502	372	380	372
q17	982	662	701	662
q18	8098	7523	7500	7500
q19	6894	1447	1496	1447
q20	782	323	320	320
q21	4845	3164	3294	3164
q22	343	288	290	288
Total cold run time: 117459 ms
Total hot run time: 39982 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4369	4287	4273	4273
q2	373	275	251	251
q3	3030	2943	2891	2891
q4	2023	1662	1774	1662
q5	5568	5535	5534	5534
q6	224	130	134	130
q7	2195	1899	1857	1857
q8	3283	3419	3424	3419
q9	8761	8850	8879	8850
q10	4177	3835	3777	3777
q11	588	516	496	496
q12	819	634	633	633
q13	16213	3150	3217	3150
q14	309	268	302	268
q15	513	484	492	484
q16	497	433	435	433
q17	1814	1536	1513	1513
q18	8191	7949	7884	7884
q19	4474	1563	1399	1399
q20	2188	1855	1855	1855
q21	5278	4755	4783	4755
q22	592	510	522	510
Total cold run time: 75479 ms
Total hot run time: 56024 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 172104 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 367c679f2bf824ddb59c91f6de06d34ee39e66bd, data reload: false

query1	914	373	363	363
query2	6438	1929	1821	1821
query3	6680	208	217	208
query4	25632	17479	17292	17292
query5	3818	479	465	465
query6	247	167	171	167
query7	4575	303	292	292
query8	238	186	212	186
query9	8456	2379	2348	2348
query10	444	293	273	273
query11	10641	10087	9996	9996
query12	117	82	82	82
query13	1658	371	359	359
query14	9909	7787	6825	6825
query15	221	168	168	168
query16	7749	323	312	312
query17	1790	535	550	535
query18	1880	288	273	273
query19	203	153	147	147
query20	91	83	80	80
query21	214	132	129	129
query22	4319	4091	4022	4022
query23	34029	33814	33705	33705
query24	10875	2948	2907	2907
query25	603	382	388	382
query26	698	150	147	147
query27	2291	281	278	278
query28	6148	2048	2046	2046
query29	896	630	646	630
query30	246	152	151	151
query31	979	771	756	756
query32	98	53	55	53
query33	629	300	296	296
query34	915	493	487	487
query35	689	597	583	583
query36	1137	982	976	976
query37	137	79	79	79
query38	2970	2849	2804	2804
query39	900	855	861	855
query40	202	121	115	115
query41	41	47	42	42
query42	109	98	98	98
query43	512	438	469	438
query44	1075	728	713	713
query45	190	160	164	160
query46	1071	705	722	705
query47	1891	1778	1778	1778
query48	370	290	287	287
query49	844	406	411	406
query50	777	383	383	383
query51	6883	6772	6698	6698
query52	100	106	92	92
query53	352	284	277	277
query54	860	436	432	432
query55	76	72	77	72
query56	283	253	282	253
query57	1115	1103	1059	1059
query58	248	227	246	227
query59	2824	2619	2820	2619
query60	303	266	281	266
query61	96	90	105	90
query62	813	630	631	630
query63	316	294	284	284
query64	9334	2214	1660	1660
query65	3163	3108	3086	3086
query66	738	326	330	326
query67	15306	15156	14872	14872
query68	4595	533	548	533
query69	552	324	314	314
query70	1215	1130	1145	1130
query71	387	283	272	272
query72	8978	5676	5404	5404
query73	792	326	322	322
query74	6248	5701	5676	5676
query75	3465	2707	2671	2671
query76	2779	904	952	904
query77	654	307	299	299
query78	9687	9487	8918	8918
query79	2773	512	520	512
query80	1481	477	467	467
query81	581	221	221	221
query82	975	132	132	132
query83	327	167	163	163
query84	269	86	94	86
query85	1931	315	296	296
query86	403	290	329	290
query87	3319	3089	3117	3089
query88	4640	2354	2356	2354
query89	488	402	391	391
query90	1784	194	193	193
query91	130	100	170	100
query92	60	47	51	47
query93	4830	499	496	496
query94	957	212	209	209
query95	400	307	320	307
query96	616	273	273	273
query97	3197	3009	3038	3009
query98	222	200	193	193
query99	1568	1287	1288	1287
Total cold run time: 280669 ms
Total hot run time: 172104 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.71 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 367c679f2bf824ddb59c91f6de06d34ee39e66bd, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.49	0.50	0.49
query6	1.13	0.73	0.73
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.55	0.49	0.50
query10	0.55	0.54	0.53
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.59	0.58
query14	0.77	0.78	0.76
query15	0.85	0.81	0.82
query16	0.35	0.35	0.36
query17	0.98	0.98	0.96
query18	0.21	0.21	0.22
query19	1.83	1.70	1.70
query20	0.01	0.01	0.01
query21	15.39	0.75	0.67
query22	4.24	6.90	2.15
query23	18.34	1.38	1.24
query24	2.09	0.24	0.23
query25	0.15	0.08	0.10
query26	0.29	0.20	0.20
query27	0.44	0.23	0.22
query28	13.20	1.02	0.99
query29	12.56	3.33	3.31
query30	0.25	0.06	0.05
query31	2.87	0.39	0.39
query32	3.27	0.49	0.46
query33	2.87	2.85	2.90
query34	17.18	4.33	4.40
query35	4.43	4.41	4.43
query36	0.66	0.47	0.49
query37	0.18	0.16	0.16
query38	0.15	0.14	0.15
query39	0.05	0.03	0.03
query40	0.16	0.12	0.12
query41	0.09	0.04	0.05
query42	0.06	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.67 s
Total hot run time: 30.71 s

zhannngchen
zhannngchen approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 497a1c9 into apache:master Jul 18, 2024
27 of 30 checks passed
dataroaring pushed a commit that referenced this pull request Jul 19, 2024
@kaijchen @dataroaring
[config](be) add be config migration_lock_timeout_ms (#38000)
3a53153 
## Proposed changes

Add be config `migration_lock_timeout_ms` and increase default value
from `30ms` to `1000ms`.
kaijchen added a commit to kaijchen/doris that referenced this pull request Jul 25, 2024
@kaijchen
[config](be) add be config migration_lock_timeout_ms (apache#38000)
7ab2e0d 
Add be config `migration_lock_timeout_ms` and increase default value
from `30ms` to `1000ms`.
@kaijchen kaijchen mentioned this pull request Jul 25, 2024
Merged
kaijchen added a commit to kaijchen/doris that referenced this pull request Jul 25, 2024
@kaijchen
[config](be) add be config migration_lock_timeout_ms (apache#38000)
f873c54 
## Proposed changes

Add be config `migration_lock_timeout_ms` and increase default value
from `30ms` to `1000ms`.
@kaijchen kaijchen mentioned this pull request Jul 25, 2024
Merged
dataroaring pushed a commit that referenced this pull request Jul 25, 2024
@kaijchen
[config](be) add be config migration_lock_timeout_ms (#38000) (#38335)
7af9dda 
backport #38000
dataroaring pushed a commit that referenced this pull request Jul 25, 2024
@kaijchen
[config](be) add be config migration_lock_timeout_ms (#38000) (#38337)
0152a4e 
backport #38000
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@kaijchen
[config](be) add be config migration_lock_timeout_ms (apache#38000) (a…
687aa55 
…pache#38335)

backport apache#38000
@gavinchou gavinchou mentioned this pull request Aug 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dataroaring dataroaring dataroaring approved these changes

@zhannngchen zhannngchen zhannngchen approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.14-merged dev/2.1.6-merged dev/3.0.1-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kaijchen @doris-robot @zhannngchen @dataroaring