Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config](be) add be config migration_lock_timeout_ms (#38000) #38335

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

kaijchen
Copy link
Contributor

backport #38000

Add be config `migration_lock_timeout_ms` and increase default value
from `30ms` to `1000ms`.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaijchen
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 49946 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7ab2e0da9eb5748303a544e45c77812569295427, data reload: false

------ Round 1 ----------------------------------
q1	17645	4422	4357	4357
q2	2073	170	157	157
q3	10419	1885	1952	1885
q4	10214	1265	1316	1265
q5	8609	4112	3927	3927
q6	235	124	148	124
q7	2081	1623	1592	1592
q8	9335	2750	2726	2726
q9	10733	10427	10402	10402
q10	8669	3506	3526	3506
q11	426	250	249	249
q12	473	299	314	299
q13	18354	3949	4088	3949
q14	357	320	323	320
q15	517	460	463	460
q16	665	567	585	567
q17	1143	961	995	961
q18	7312	6734	6974	6734
q19	1807	1678	1641	1641
q20	565	307	301	301
q21	4486	4095	4086	4086
q22	534	448	438	438
Total cold run time: 116652 ms
Total hot run time: 49946 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4345	4324	4273	4273
q2	326	228	229	228
q3	4167	4160	4129	4129
q4	2776	2764	2743	2743
q5	7252	7162	7140	7140
q6	241	121	117	117
q7	3230	2858	2859	2858
q8	4393	4452	4485	4452
q9	16853	16711	16743	16711
q10	4221	4253	4237	4237
q11	740	708	691	691
q12	1013	881	860	860
q13	6760	3757	3737	3737
q14	457	421	426	421
q15	509	464	458	458
q16	735	672	677	672
q17	3801	3843	3774	3774
q18	8865	8807	8866	8807
q19	1730	1722	1650	1650
q20	2436	2093	2092	2092
q21	8469	8479	8495	8479
q22	1070	947	985	947
Total cold run time: 84389 ms
Total hot run time: 79476 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.80% (8115/21466)
Line Coverage: 29.47% (66523/225743)
Region Coverage: 28.94% (34282/118466)
Branch Coverage: 24.82% (17611/70960)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7ab2e0da9eb5748303a544e45c77812569295427_7ab2e0da9eb5748303a544e45c77812569295427/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 205688 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7ab2e0da9eb5748303a544e45c77812569295427, data reload: false

query1	913	390	410	390
query2	6556	2549	2623	2549
query3	6921	205	204	204
query4	20101	17948	17997	17948
query5	19731	6500	6588	6500
query6	288	217	230	217
query7	4161	302	314	302
query8	460	391	411	391
query9	3133	2701	2643	2643
query10	419	286	292	286
query11	11397	10626	10693	10626
query12	118	78	77	77
query13	5596	689	698	689
query14	17578	13579	13586	13579
query15	365	245	256	245
query16	6453	283	267	267
query17	1721	1464	884	884
query18	2290	419	415	415
query19	205	150	149	149
query20	82	79	76	76
query21	190	102	93	93
query22	5195	5142	5024	5024
query23	32413	32016	32038	32016
query24	6994	6513	6516	6513
query25	527	413	438	413
query26	532	162	165	162
query27	1880	296	288	288
query28	6145	2410	2347	2347
query29	2853	2868	2792	2792
query30	243	176	165	165
query31	901	725	742	725
query32	71	65	59	59
query33	406	265	245	245
query34	848	477	478	477
query35	1114	931	928	928
query36	1283	1449	1172	1172
query37	88	60	58	58
query38	3135	2917	2971	2917
query39	1415	1319	1326	1319
query40	200	90	98	90
query41	52	45	45	45
query42	83	87	76	76
query43	688	700	687	687
query44	1111	710	718	710
query45	248	236	236	236
query46	1238	958	980	958
query47	2002	1788	1780	1780
query48	1031	721	709	709
query49	636	368	377	368
query50	867	630	593	593
query51	4748	4636	4709	4636
query52	92	84	87	84
query53	460	325	329	325
query54	2669	2468	2450	2450
query55	83	84	82	82
query56	230	239	221	221
query57	1157	1089	1081	1081
query58	214	202	191	191
query59	3979	3936	3845	3845
query60	215	191	209	191
query61	101	99	98	98
query62	865	447	496	447
query63	501	340	345	340
query64	2580	1544	1509	1509
query65	3640	3583	3523	3523
query66	761	369	385	369
query67	16552	17594	17281	17281
query68	6395	664	640	640
query69	567	345	343	343
query70	1457	1336	1361	1336
query71	407	306	326	306
query72	6552	3512	3495	3495
query73	727	325	314	314
query74	6347	5839	5807	5807
query75	4799	3739	3755	3739
query76	4079	1174	1212	1174
query77	550	254	264	254
query78	12523	11620	11479	11479
query79	7416	655	644	644
query80	2665	409	412	409
query81	527	237	232	232
query82	1597	97	98	97
query83	230	142	136	136
query84	265	71	72	71
query85	1399	326	332	326
query86	364	292	337	292
query87	3262	3004	3001	3001
query88	5021	2317	2309	2309
query89	360	273	284	273
query90	1740	207	217	207
query91	180	141	141	141
query92	64	51	56	51
query93	3096	554	598	554
query94	896	210	200	200
query95	1088	1066	1060	1060
query96	645	324	334	324
query97	6460	6344	6360	6344
query98	195	178	173	173
query99	3049	975	882	882
Total cold run time: 306646 ms
Total hot run time: 205688 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.6 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7ab2e0da9eb5748303a544e45c77812569295427, data reload: false

query1	0.03	0.02	0.02
query2	0.06	0.03	0.02
query3	0.24	0.04	0.04
query4	1.81	0.06	0.06
query5	0.53	0.52	0.53
query6	1.28	0.61	0.62
query7	0.02	0.01	0.01
query8	0.03	0.03	0.02
query9	0.53	0.48	0.46
query10	0.54	0.54	0.52
query11	0.12	0.08	0.08
query12	0.12	0.09	0.09
query13	0.61	0.61	0.62
query14	0.79	0.79	0.80
query15	0.78	0.76	0.75
query16	0.36	0.38	0.35
query17	0.97	1.00	0.99
query18	0.23	0.25	0.25
query19	1.86	1.86	1.84
query20	0.02	0.01	0.01
query21	15.46	0.55	0.54
query22	2.06	2.05	1.61
query23	17.31	0.97	0.91
query24	4.67	0.95	1.40
query25	0.42	0.13	0.04
query26	0.47	0.15	0.16
query27	0.05	0.04	0.03
query28	8.11	0.79	0.72
query29	12.65	2.36	2.21
query30	0.56	0.56	0.54
query31	2.81	0.39	0.38
query32	3.38	0.50	0.50
query33	3.11	3.06	3.11
query34	15.25	4.83	4.81
query35	4.87	4.85	4.83
query36	1.09	1.02	1.02
query37	0.06	0.05	0.05
query38	0.04	0.02	0.02
query39	0.02	0.02	0.02
query40	0.15	0.14	0.14
query41	0.06	0.02	0.01
query42	0.02	0.01	0.02
query43	0.03	0.01	0.01
Total cold run time: 103.58 s
Total hot run time: 30.6 s

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 7ab2e0da9eb5748303a544e45c77812569295427 with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.1 seconds inserted 10000000 Rows, about 473K ops/s

@dataroaring dataroaring merged commit 7af9dda into apache:branch-2.0 Jul 25, 2024
23 of 25 checks passed
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants