[enhancement](nereids)optimized aggregate node's error msg #38122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 39572 ms |
TPC-DS: Total hot run time: 173277 ms |
ClickBench: Total hot run time: 30.86 s |
morrySnow
reviewed
Jul 22, 2024
| @@ -622,6 +623,14 @@ private Plan bindAggregate(MatchingContext<LogicalAggregate<Plan>> ctx) { | |||
| SimpleExprAnalyzer aggOutputAnalyzer = buildSimpleExprAnalyzer( | |||
| agg, cascadesContext, agg.children(), true, true); | |||
| List<NamedExpression> boundAggOutput = aggOutputAnalyzer.analyzeToList(agg.getOutputExpressions()); | |||
| if (boundAggOutput.size() == 1 && boundAggOutput.get(0) instanceof BoundStar) { | |||
There was a problem hiding this comment.
should be contains BoundStar? what about select *, c1 from t group by 1
starocean999
force-pushed
the
nereids_1225
branch
from
d10a37f to
7525433
Compare
|
run buildall |
TPC-H: Total hot run time: 40350 ms |
TPC-DS: Total hot run time: 173623 ms |
ClickBench: Total hot run time: 31.18 s |
morrySnow
approved these changes
Jul 22, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
englefly
approved these changes
Jul 23, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 24, 2024
## Proposed changes
```
create table t1
(
c1 bigint,
c2 bigint
)
DISTRIBUTED BY HASH(c1) BUCKETS 3
PROPERTIES ("replication_num" = "1");
```
sql
`select * from t1 group by 1;`
the error msg before:
ERROR 1105 (HY000): errCode = 2, detailMessage = Invalid call to toSlot
on unbound object
after:
ERROR 1105 (HY000): errCode = 2, detailMessage = c2 not in aggregate's
output
Issue Number: close #xxx
<!--Describe your changes.-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
sql
select * from t1 group by 1;the error msg before:
ERROR 1105 (HY000): errCode = 2, detailMessage = Invalid call to toSlot on unbound object
after:
ERROR 1105 (HY000): errCode = 2, detailMessage = c2 not in aggregate's output
Issue Number: close #xxx