[fix](date_function) fix str_to_date function return wrong microsecond issue #47129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
TPC-H: Total hot run time: 32247 ms |
TPC-DS: Total hot run time: 188727 ms |
ClickBench: Total hot run time: 31.59 s |
| ) | ||
| """ | ||
| sql """ insert into ${tableName} values (3, 'Carl','2024-12-29 10:11:12') """ | ||
| def result1 = try_sql """ |
There was a problem hiding this comment.
should also check all constant parameters for fe fold constant
There was a problem hiding this comment.
like: select cast(str_to_date('2024-12-29 10:11:12', '%Y-%m-%d %H:%i:%s.%f') as string);
|
run buildall |
TPC-H: Total hot run time: 32730 ms |
TPC-DS: Total hot run time: 187521 ms |
ClickBench: Total hot run time: 30.77 s |
LiBinfeng-01
approved these changes
Jan 20, 2025
|
PR approved by anyone and no changes requested. |
englefly
approved these changes
Jan 20, 2025
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
16 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
…d issue (#47129) ### What problem does this PR solve? Issue Number: close #47105 Related PR: #24932 Problem Summary: ### Release note str_to_date always return microsecond part for datetime even if user does not specfic %f in date format string. This is wrong. mysql> select id,str_to_date(dt, '%Y-%m-%d %H:%i:%s') from test1 limit 1; +------+--------------------------------------+ | id | str_to_date(dt, '%Y-%m-%d %H:%i:%s') | +------+--------------------------------------+ | 2 | 2024-12-28 10:11:12.000000 | +------+--------------------------------------+ and constant fold scenario is wrong too: mysql> select cast(str_to_date('2025-01-17 11:59:30', '%Y-%m-%d %H:%i:%s') as string); +--------------------------------------------------------------------------+ | cast(str_to_date('2025-01-17 11:59:30', '%Y-%m-%d %H:%i:%s') as TEXT) | +--------------------------------------------------------------------------+ | 2025-01-17 11:59:30.000000 | +--------------------------------------------------------------------------+ ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
16 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
…d issue (#47129) ### What problem does this PR solve? Issue Number: close #47105 Related PR: #24932 Problem Summary: ### Release note str_to_date always return microsecond part for datetime even if user does not specfic %f in date format string. This is wrong. mysql> select id,str_to_date(dt, '%Y-%m-%d %H:%i:%s') from test1 limit 1; +------+--------------------------------------+ | id | str_to_date(dt, '%Y-%m-%d %H:%i:%s') | +------+--------------------------------------+ | 2 | 2024-12-28 10:11:12.000000 | +------+--------------------------------------+ and constant fold scenario is wrong too: mysql> select cast(str_to_date('2025-01-17 11:59:30', '%Y-%m-%d %H:%i:%s') as string); +--------------------------------------------------------------------------+ | cast(str_to_date('2025-01-17 11:59:30', '%Y-%m-%d %H:%i:%s') as TEXT) | +--------------------------------------------------------------------------+ | 2025-01-17 11:59:30.000000 | +--------------------------------------------------------------------------+ ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [x] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. <!-- Explain the behavior change --> - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #47105
Related PR: #24932
Problem Summary:
Release note
str_to_date always return microsecond part for datetime even if user does not specfic %f in date format string. This is wrong.
mysql> select id,str_to_date(dt, '%Y-%m-%d %H:%i:%s') from test1 limit 1;
+------+--------------------------------------+
| id | str_to_date(dt, '%Y-%m-%d %H:%i:%s') |
+------+--------------------------------------+
| 2 | 2024-12-28 10:11:12.000000 |
+------+--------------------------------------+
and constant fold scenario is wrong too:
mysql> select cast(str_to_date('2025-01-17 11:59:30', '%Y-%m-%d %H:%i:%s') as string);
+--------------------------------------------------------------------------+
| cast(str_to_date('2025-01-17 11:59:30', '%Y-%m-%d %H:%i:%s') as TEXT) |
+--------------------------------------------------------------------------+
| 2025-01-17 11:59:30.000000 |
+--------------------------------------------------------------------------+
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)