Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: change service_name like java style on nacos #1348

Conversation

ChangedenCZD
Copy link
Contributor

fixed: #1331

What this PR does:

Which issue(s) this PR fixes:

Fixes #1331

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@LaurenceLiZhixin
Copy link
Contributor

LaurenceLiZhixin commented Jul 29, 2021

Pls Change your target branch to 1.5/3.0, and the ci check may pass.

@ChangedenCZD
Copy link
Contributor Author

@LaurenceLiZhixin 已切换至3.0

@ChangedenCZD ChangedenCZD changed the base branch from master to 3.0 July 29, 2021 15:05
@AlexStocks
Copy link
Contributor

Pls change the pr title. We will list ur pr when we publish a new dubbogo version. This title is so confusing.

@ChangedenCZD ChangedenCZD changed the title Fix: #1331 Fix: change service_name like java style on nacos Jul 30, 2021
@ChangedenCZD
Copy link
Contributor Author

Pls change the pr title. We will list ur pr when we publish a new dubbogo version. This title is so confusing.

done

@ChangedenCZD ChangedenCZD deleted the feature/service-name-like-java-style-on-nacos branch July 30, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nacos 注册的group和version未和java侧对齐
6 participants