Ftr: Add config loader hooks for 3.0 #1370
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 9, 2021 20:12
- BeforeShutdownHook - BeforeConsumerConnectHook - ConsumerConnectSuccessHook - ConsumerConnectFailHook - AllConsumerConnectCompleteHook - BeforeProviderConnectHook - ProviderConnectSuccessHook - ProviderConnectFailHook - AllProviderConnectCompleteHook UT: - config_loader_test.TestLoadWithLoaderHooks
Codecov Report
@@ Coverage Diff @@
## 3.0 #1370 +/- ##
==========================================
+ Coverage 54.95% 55.19% +0.23%
==========================================
Files 272 273 +1
Lines 14755 14934 +179
==========================================
+ Hits 8109 8243 +134
- Misses 5769 5812 +43
- Partials 877 879 +2
Continue to review full report at Codecov.
|
added 2 commits
August 10, 2021 10:57
|
ChangedenCZD
changed the title
|
LaurenceLiZhixin
requested review from
gaoxinge,
AlexStocks and
LaurenceLiZhixin
and removed request for
AlexStocks,
gaoxinge and
LaurenceLiZhixin
justxuewei
reviewed
Aug 20, 2021
| hooks = []LoaderHook{} | ||
| } | ||
| loaderHooks[hookType] = append(hooks, hook) | ||
| } |
There was a problem hiding this comment.
It seems that hooks is a useless variable in this case.
if _, ok := loaderHooks[hookType]; !ok {
loaderHooks[hookType] = make([]LoaderHook)
}
loaderHooks[hookType] = append(loaderHooks[hookType], hook)
justxuewei
reviewed
Aug 20, 2021
| @@ -59,6 +59,8 @@ var ( | |||
| confBaseFile string | |||
| uniformVirtualServiceConfigPath string | |||
| uniformDestRuleConfigPath string | |||
|
|
|||
| loaderHooks map[string][]LoaderHook | |||
There was a problem hiding this comment.
Why not initializes loaderHooks here? If not initializes, you should handle the case that loaderHooks is empty in AddLoaderHooks and RemoveLoaderHooks method.
justxuewei
reviewed
Aug 20, 2021
| } else { | ||
| loaderHooks[hookType] = newHooks | ||
| } | ||
| break |
There was a problem hiding this comment.
if len(loaderHooks[hookType]) == 1 {
delete(loaderHooks, hookType)
} else {
loaderHooks[hookType] = append(loaderHooks[hookType][:index], loaderHooks[hookType][index+1:]...)
}
justxuewei
reviewed
Aug 20, 2021
| ) | ||
|
|
||
| const ( | ||
| hookParams = constant.HookParams |
There was a problem hiding this comment.
use constant.HookParams directly please
|
暂时先关闭，后期改进 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Hook Type:
Create Instance:
Add/Remove Hooks:
Unit Test:
Which issue(s) this PR fixes:
Fixes #1364
Special notes for your reviewer:
Does this PR introduce a user-facing change?: