-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr: Add config loader hooks for 1.5 #1372
Closed
ChangedenCZD
wants to merge
6
commits into
apache:1.5
from
chans-open-source:feature/config-load-with-loader-hook-for-1.5
Closed
Ftr: Add config loader hooks for 1.5 #1372
ChangedenCZD
wants to merge
6
commits into
apache:1.5
from
chans-open-source:feature/config-load-with-loader-hook-for-1.5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add: - BeforeShutdownHook - BeforeConsumerConnectHook - ConsumerConnectSuccessHook - ConsumerConnectFailHook - AllConsumerConnectCompleteHook - BeforeProviderConnectHook - ProviderConnectSuccessHook - ProviderConnectFailHook - AllProviderConnectCompleteHook Tst: - config_loader_test.TestLoadWithLoaderHooks
…th-loader-hook-for-1.5
LaurenceLiZhixin
requested review from
LaurenceLiZhixin,
gaoxinge and
AlexStocks
and removed request for
LaurenceLiZhixin
August 13, 2021 12:30
ChangedenCZD
changed the title
Ftr: Add config loader hooks for 1.5.
Ftr: Add config loader hooks for 1.5
Aug 17, 2021
使用事件分发机制实现 #1405 |
XiaoWeiKIN
reviewed
Aug 24, 2021
XiaoWeiKIN
reviewed
Aug 24, 2021
XiaoWeiKIN
reviewed
Aug 24, 2021
@wangxw666 1.5版本的已改为 #1405 这个解决方案,3.0的建议废除原有的分发机制,改为Hook |
Mulavar
reviewed
Aug 24, 2021
Mulavar
reviewed
Aug 24, 2021
cjphaha
reviewed
Aug 24, 2021
Codecov Report
@@ Coverage Diff @@
## 1.5 #1372 +/- ##
==========================================
- Coverage 58.07% 55.72% -2.35%
==========================================
Files 275 277 +2
Lines 13381 16119 +2738
==========================================
+ Hits 7771 8983 +1212
- Misses 4650 6197 +1547
+ Partials 960 939 -21
Continue to review full report at Codecov.
|
ChangedenCZD
deleted the
feature/config-load-with-loader-hook-for-1.5
branch
September 9, 2021 08:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hook触发流程图
AddLoaderHooks
What this PR does:
Which issue(s) this PR fixes:
Fixes #1364
Special notes for your reviewer:
Does this PR introduce a user-facing change?: