Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1998]fix a bug where filter was not currently working properly in triple protocol #1999

Merged
merged 1 commit into from
Jul 30, 2022

Conversation

Mulavar
Copy link
Member

@Mulavar Mulavar commented Jul 26, 2022

…fix some spelling mistake

What this PR does:
fix a bug where filter was not currently working properly and fix some spelling mistake

Which issue(s) this PR fixes:
Fixes #1988

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2022

Codecov Report

Merging #1999 (089bd3c) into 3.0 (de6fcfb) will increase coverage by 0.15%.
The diff coverage is 49.09%.

@@            Coverage Diff             @@
##              3.0    #1999      +/-   ##
==========================================
+ Coverage   44.32%   44.47%   +0.15%     
==========================================
  Files         283      283              
  Lines       17067    17067              
==========================================
+ Hits         7565     7591      +26     
+ Misses       8696     8673      -23     
+ Partials      806      803       -3     
Impacted Files Coverage Δ
protocol/dubbo/dubbo_invoker.go 27.83% <0.00%> (ø)
protocol/protocol.go 0.00% <0.00%> (ø)
protocol/rest/rest_exporter.go 0.00% <0.00%> (ø)
remoting/zookeeper/listener.go 0.00% <ø> (ø)
config/service_config.go 53.04% <50.00%> (ø)
filter/token/filter.go 53.12% <58.82%> (-6.88%) ⬇️
protocol/dubbo3/dubbo3_exporter.go 83.33% <66.66%> (ø)
protocol/dubbo3/dubbo3_invoker.go 55.65% <66.66%> (ø)
registry/protocol/protocol.go 72.10% <75.00%> (ø)
protocol/dubbo/dubbo_exporter.go 100.00% <100.00%> (ø)
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

…y in triple protocol and fix some spelling mistake
@justxuewei
Copy link
Member

justxuewei commented Jul 27, 2022

@Mulavar The wrong branch (master) is set, please submit a new PR and set to the correct branch.

@justxuewei justxuewei closed this Jul 27, 2022
@Mulavar Mulavar reopened this Jul 28, 2022
@Mulavar Mulavar changed the base branch from master to 3.0 July 28, 2022 08:17
@Mulavar Mulavar changed the title [#1998]fix a bug where filter was not currently working properly and … [#1998]fix a bug where filter was not currently working properly in triple protocol Jul 28, 2022
@Mulavar
Copy link
Member Author

Mulavar commented Jul 28, 2022

I've changed the base branch that this pr should be merged into and re-open the pr.

@AlexStocks AlexStocks merged commit 013f0b2 into apache:3.0 Jul 30, 2022
@Mulavar Mulavar mentioned this pull request Aug 1, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants