Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: token filter type assertion #2001

Closed
wants to merge 1 commit into from

Conversation

AnneYang720
Copy link

What this PR does:
Fix type assertion in token filter.
remoteTkn must be assert to []string[0], because of http2 header limitation.

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@Mulavar
Copy link
Member

Mulavar commented Aug 1, 2022

I'm sorry that issue #1998 has been fixed, the purpose of this pr is the same as the other pr #1999 .
I saw your pr, and maybe you forgot that the token filter should be compatible with the dubbo protocol too, so we need to check both type assertion with string and []string.
@AnneYang720

@Mulavar Mulavar closed this Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants