Fix problem of rest protocol PR #352 #395
Conversation
# Conflicts: # cluster/directory/base_directory.go # common/constant/env.go # common/constant/key.go # config_center/dynamic_configuration.go # go.mod # registry/directory/directory.go
Imp: trace error of getGettyRpcClient
Mrg: merge 1.3
add healthcheck router
if zkJar not exist,it will download it.
|
@Patrick0308 would u change this pr name pls? fix what rest protocol? If there is an issue, you can fix #issue-id. If not, you should write it clearly. If the title is not clearly, the release note is not readable. |
Codecov Report
@@ Coverage Diff @@
## feature/rest #395 +/- ##
================================================
- Coverage 69.19% 66.84% -2.36%
================================================
Files 171 158 -13
Lines 9697 8213 -1484
================================================
- Hits 6710 5490 -1220
+ Misses 2382 2200 -182
+ Partials 605 523 -82
Continue to review full report at Codecov.
|
|
@AlexStocks This pr will be merged to the branch of feature/rest. You can see detail in Rest Protocol Pull Request . |
|
@flycash pls own this pr and rename the pr title. |
| } | ||
|
|
||
| // byPriority Sort by priority | ||
| type byPriority []router.Router |
There was a problem hiding this comment.
can u change its name to PriorityArray?
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: