Add: interface of Metadata report #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cluster/directory/base_directory.go # common/constant/env.go # common/constant/key.go # config_center/dynamic_configuration.go # go.mod # registry/directory/directory.go
add healthcheck router
if zkJar not exist,it will download it.
user can add attachment
Add: Grpc tracing for client and server
AlexStocks
reviewed
Mar 14, 2020
| metaDataReportFactories = make(map[string]func() metadata.MetadataReportFactory) | ||
| ) | ||
|
|
||
| // SetMetadataReportFactory ... |
| metaDataReportFactories[name] = v | ||
| } | ||
|
|
||
| // GetConfigCenterFactory ... |
| // GetConfigCenterFactory ... | ||
| func GetMetadataReportFactory(name string) metadata.MetadataReportFactory { | ||
| if metaDataReportFactories[name] == nil { | ||
| panic("metadata report for " + name + " is not existing, make sure you have import the package.") |
There was a problem hiding this comment.
panic? maybe u should return a error.
There was a problem hiding this comment.
Extension is designed for dubbogo plugin system, we can not start the program when user's plugin is not exist.
metadata/instance.go
Outdated
| once sync.Once | ||
| ) | ||
|
|
||
| // GetEnvInstance ... |
There was a problem hiding this comment.
delete the unuseful remark or add useful remark.
metadata/instance.go
Outdated
| }) | ||
| } | ||
|
|
||
| func GetMetadataReportInstance() MetadataReport { |
| var ( | ||
| MetadataReportInstance MetadataReport | ||
| ) | ||
|
|
|
@hxmhlt pls add some words of "What this PR does:" for this pr. |
Codecov Report
@@ Coverage Diff @@
## feature/dubbo-2.7.5 #405 +/- ##
====================================================
Coverage 67.19% 67.19%
====================================================
Files 163 163
Lines 8387 8387
====================================================
Hits 5636 5636
Misses 2226 2226
Partials 525 525 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
define interface of Metadata report
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: