You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
org.apache.dubbo.remoting.exchange.support.DefaultFuture#closeChannel doesn't work as expected since the channel instances to be compared do not have correct equals() implementation:
publicstaticvoidcloseChannel(Channelchannel) {
for (Map.Entry<Long, Channel> entry : CHANNELS.entrySet()) {
if (channel.equals(entry.getValue())) { // in netty4, channel is NettyChannel, but entry.getValue() is NettyClient, equals will return false.DefaultFuturefuture = getFuture(entry.getKey());
if (future != null && !future.isDone()) {
ResponsedisconnectResponse = newResponse(future.getId());
disconnectResponse.setStatus(Response.CHANNEL_INACTIVE);
disconnectResponse.setErrorMessage("Channel " +
channel +
" is inactive. Directly return the unFinished request : " +
future.getRequest());
DefaultFuture.received(channel, disconnectResponse);
}
}
}
}
… closeChannel doesn't work as expected (#4700)
* issue #4699: org.apache.dubbo.remoting.exchange.support.DefaultFuture#closeChannel doesn't work as expected
* Revert "issue #4699: org.apache.dubbo.remoting.exchange.support.DefaultFuture#closeChannel doesn't work as expected"
org.apache.dubbo.remoting.exchange.support.DefaultFuture#closeChannel doesn't work as expected since the channel instances to be compared do not have correct equals() implementation:
This is the root cause of issue 1 in #1968.
The text was updated successfully, but these errors were encountered: