Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #4699: org.apache.dubbo.remoting.exchange.support.DefaultFuture closeChannel doesn't work as expected #4700

Merged
merged 3 commits into from
Sep 5, 2019

Conversation

beiwei30
Copy link
Member

What is the purpose of the change

fix issue #4699, #4694

and issue 1 in #1968

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

beiwei30 added 2 commits July 30, 2019 16:54
…ltFuture#closeChannel doesn't work as expected"

This reverts commit 4aa12c6
Copy link
Member

@carryxyh carryxyh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change content of HeaderExchangeChannel#request(java.lang.Object, int) from
DefaultFuture future = DefaultFuture.newFuture(channel, req, timeout); to DefaultFuture future = DefaultFuture.newFuture(this, req, timeout); will be a better way.

Just check the code, hasn't verify it.

@cvictory cvictory requested a review from kezhenxu94 September 4, 2019 09:37
@hengyunabc
Copy link
Contributor

LGTM.

@beiwei30
Copy link
Member Author

beiwei30 commented Sep 5, 2019

change content of HeaderExchangeChannel#request(java.lang.Object, int) from
DefaultFuture future = DefaultFuture.newFuture(channel, req, timeout); to DefaultFuture future = DefaultFuture.newFuture(this, req, timeout); will be a better way.

Just check the code, hasn't verify it.

Not sure if it works or not, @carryxyh, you may consider to come up a better approach with another pull request.

@cvictory cvictory requested review from cvictory and removed request for kezhenxu94 September 5, 2019 06:39
Copy link
Contributor

@cvictory cvictory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cvictory cvictory merged commit cb1331e into apache:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants