Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance serializable check option #11460

Merged
merged 2 commits into from
Feb 14, 2023
Merged

Enhance serializable check option #11460

merged 2 commits into from
Feb 14, 2023

Conversation

AlbumenJ
Copy link
Member

@AlbumenJ AlbumenJ commented Feb 5, 2023

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
18.8% 18.8% Duplication

@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2023

Codecov Report

Attention: Patch coverage is 6.45161% with 29 lines in your changes missing coverage. Please review.

Project coverage is 64.62%. Comparing base (34b92b0) to head (36e2247).
Report is 84 commits behind head on 3.1.

Files with missing lines Patch % Lines
.../serialize/hessian2/Hessian2SerializerFactory.java 16.66% 7 Missing and 3 partials ⚠️
...mmon/serialize/fastjson2/FastJson2ObjectInput.java 0.00% 8 Missing ⚠️
...mon/serialize/fastjson2/FastJson2ObjectOutput.java 0.00% 5 Missing ⚠️
...on/serialize/fastjson2/FastJson2Serialization.java 0.00% 5 Missing ⚠️
...bbo/common/utils/DefaultSerializeClassChecker.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                3.1   #11460      +/-   ##
============================================
- Coverage     64.67%   64.62%   -0.05%     
  Complexity       14       14              
============================================
  Files          1431     1431              
  Lines         59969    59995      +26     
  Branches       8807     8815       +8     
============================================
- Hits          38786    38774      -12     
- Misses        17111    17142      +31     
- Partials       4072     4079       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlbumenJ AlbumenJ merged commit 5a27cb5 into apache:3.1 Feb 14, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 16, 2023
* mytang0/3.2: (33 commits)
  Fix conflict
  Update codecov config (apache#11580)
  Set timeout value to string (apache#11565)
  Skip mapping retry if metadata config is invalid (apache#11323)
  Fix stackoverflow in SerializeSecurityConfigurator (apache#11561)
  Revert clear response operation of timeoutfilter (apache#11562)
  Fix hessian2 serializable check (apache#11573)
  feat: fix oom (apache#11571)
  Enhance service discovery update interval (apache#11223)
  Metrics code opt: redundant, modifier, magic (apache#11553)
  Perfect some code (apache#11533)
  feat: dubbo provided by (apache#11390)
  Enhance serializable check option (apache#11460)
  Fix config absent when refresh (apache#11505)
  Enhance json util check (apache#11501)
  Fix the bug in LFUCache#put() method (apache#11538)
  Bump maven-assembly-plugin from 3.1.0 to 3.4.2 (apache#11547)
  Bump consul-api from 1.4.2 to 1.4.5 (apache#11545)
  Bump maven-core from 3.8.7 to 3.9.0 (apache#11546)
  Bump bytebuddy.version from 1.12.22 to 1.13.0 (apache#11548)
  ...

# Conflicts:
#	dubbo-rpc/dubbo-rpc-dubbo/src/main/java/org/apache/dubbo/rpc/protocol/dubbo/DubboInvoker.java
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 20, 2023
* origin/3.2: (22 commits)
  Update codecov config (apache#11582)
  metric package structure optimization (apache#11576)
  Fix compile
  Provides the public part of metrics data collection and export (apache#11522)
  [Triple] Fix boxed type methods (apache#11577)
  Bump to 3.2.0-beta.6-SNAPSHOT
  Fix synchronized in ModelEnvironment (apache#11584)
  Fix conflict
  Fix concurrent issue in scope model (apache#11525)
  Update codecov config (apache#11580)
  Set timeout value to string (apache#11565)
  Skip mapping retry if metadata config is invalid (apache#11323)
  Fix stackoverflow in SerializeSecurityConfigurator (apache#11561)
  Revert clear response operation of timeoutfilter (apache#11562)
  Fix hessian2 serializable check (apache#11573)
  feat: fix oom (apache#11571)
  Enhance serializable check option (apache#11460)
  Fix config absent when refresh (apache#11505)
  Enhance json util check (apache#11501)
  classNotFound (apache#11552)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants