Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Triple] Fix boxed type methods #11577

Merged
merged 3 commits into from
Feb 16, 2023
Merged

[Triple] Fix boxed type methods #11577

merged 3 commits into from
Feb 16, 2023

Conversation

guohao
Copy link
Contributor

@guohao guohao commented Feb 15, 2023

What is the purpose of the change

Fix triple protocol's wrapper mode can not recognize primitive method.

interface A{
  // call0
  void call(int a);

 // call1
  void call(Integer b);
}

When client wants to invoke call0 with argument 1,
Server will call call1 with (Integer)1

Brief changelog

  1. Pass interface's argument types instead of actual types.
  2. Delete unused methods in MultipleSerialization interface.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@guohao guohao requested a review from EarthChen February 15, 2023 06:52
@mytang0
Copy link
Member

mytang0 commented Feb 16, 2023

Partially overlaps with pr #11572

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #11577 (1761777) into 3.1 (59a62a6) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.1   #11577      +/-   ##
============================================
+ Coverage     64.66%   64.69%   +0.03%     
  Complexity       14       14              
============================================
  Files          1431     1430       -1     
  Lines         60014    60016       +2     
  Branches       8815     8822       +7     
============================================
+ Hits          38807    38829      +22     
+ Misses        17131    17114      -17     
+ Partials       4076     4073       -3     
Impacted Files Coverage Δ
...bbo/rpc/protocol/tri/ReflectionPackableMethod.java 81.18% <100.00%> (+3.95%) ⬆️
...pache/dubbo/remoting/transport/AbstractServer.java 61.03% <0.00%> (-3.90%) ⬇️
...c/main/java/org/apache/dubbo/rpc/RpcException.java 80.64% <0.00%> (-3.23%) ⬇️
...he/dubbo/registry/zookeeper/ZookeeperRegistry.java 60.00% <0.00%> (-2.11%) ⬇️
...ry/client/metadata/MetadataServiceNameMapping.java 85.91% <0.00%> (-1.23%) ⬇️
.../apache/dubbo/rpc/filter/ProfilerServerFilter.java 60.00% <0.00%> (-1.12%) ⬇️
...adata/store/zookeeper/ZookeeperMetadataReport.java 71.27% <0.00%> (-1.07%) ⬇️
...ava/org/apache/dubbo/rpc/proxy/InvocationUtil.java 83.87% <0.00%> (-0.98%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 76.22% <0.00%> (-0.82%) ⬇️
...org/apache/dubbo/rpc/protocol/AbstractInvoker.java 66.66% <0.00%> (-0.31%) ⬇️
... and 14 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@EarthChen EarthChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guohao guohao merged commit dc06891 into apache:3.1 Feb 16, 2023
AlbumenJ added a commit that referenced this pull request Feb 19, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 20, 2023
* origin/3.2:
  Update codecov config (apache#11582)
  [Triple] Fix boxed type methods (apache#11577)
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 20, 2023
* origin/3.2: (22 commits)
  Update codecov config (apache#11582)
  metric package structure optimization (apache#11576)
  Fix compile
  Provides the public part of metrics data collection and export (apache#11522)
  [Triple] Fix boxed type methods (apache#11577)
  Bump to 3.2.0-beta.6-SNAPSHOT
  Fix synchronized in ModelEnvironment (apache#11584)
  Fix conflict
  Fix concurrent issue in scope model (apache#11525)
  Update codecov config (apache#11580)
  Set timeout value to string (apache#11565)
  Skip mapping retry if metadata config is invalid (apache#11323)
  Fix stackoverflow in SerializeSecurityConfigurator (apache#11561)
  Revert clear response operation of timeoutfilter (apache#11562)
  Fix hessian2 serializable check (apache#11573)
  feat: fix oom (apache#11571)
  Enhance serializable check option (apache#11460)
  Fix config absent when refresh (apache#11505)
  Enhance json util check (apache#11501)
  classNotFound (apache#11552)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants