Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Consumer Metrics #11542

Merged
merged 43 commits into from
Feb 20, 2023
Merged

Add Consumer Metrics #11542

merged 43 commits into from
Feb 20, 2023

Conversation

songxiaosheng
Copy link
Member

@songxiaosheng songxiaosheng commented Feb 13, 2023

What is the purpose of the change

add some consumerMetricsKey
fix #11143

Brief changelog

Verifying this change

image

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #11542 (565e10a) into 3.2 (186fd5c) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                3.2   #11542   +/-   ##
=========================================
  Coverage     67.34%   67.35%           
  Complexity        2        2           
=========================================
  Files          1514     1514           
  Lines         62795    62823   +28     
  Branches       9207     9207           
=========================================
+ Hits          42291    42314   +23     
- Misses        16334    16340    +6     
+ Partials       4170     4169    -1     
Impacted Files Coverage Δ
...a/org/apache/dubbo/metrics/model/MethodMetric.java 67.21% <0.00%> (-5.52%) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 60.52% <0.00%> (-5.27%) ⬇️
...bbo/rpc/cluster/support/ForkingClusterInvoker.java 80.95% <0.00%> (-4.77%) ⬇️
.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java 64.00% <0.00%> (-4.00%) ⬇️
.../registry/zookeeper/ZookeeperServiceDiscovery.java 70.51% <0.00%> (-3.85%) ⬇️
...o/metrics/collector/AggregateMetricsCollector.java 83.14% <0.00%> (-1.27%) ⬇️
...bo/registry/client/OverrideInstanceAddressURL.java 33.73% <0.00%> (-1.21%) ⬇️
...n/java/org/apache/dubbo/common/bytecode/Proxy.java 69.52% <0.00%> (-0.96%) ⬇️
.../dubbo/remoting/transport/netty4/NettyChannel.java 75.00% <0.00%> (-0.72%) ⬇️
...stry/client/ServiceDiscoveryRegistryDirectory.java 71.28% <0.00%> (-0.70%) ⬇️
... and 18 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

37.6% 37.6% Coverage
0.0% 0.0% Duplication

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit f8980fe into apache:3.2 Feb 20, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 20, 2023
* origin/3.2:
  Bump version to 3.1.8-SNAPSHOT
  Add Consumer Metrics (apache#11542)
  Backport of remove apache-rat-plugin. (apache#11523) (apache#11592)
  Add hessian allow
  Prepare 3.1.7 release
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 20, 2023
* origin/3.2:
  Bump version to 3.1.8-SNAPSHOT
  Add Consumer Metrics (apache#11542)
  Backport of remove apache-rat-plugin. (apache#11523) (apache#11592)
  Add hessian allow
  Prepare 3.1.7 release
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 23, 2023
* origin/3.2: (32 commits)
  dubbo-security Jackson error (apache#11622)
  sync meter to spring boot management (apache#11630)
  Rest bugfix & optimization (apache#11617)
  Observability task: metadata center (apache#11593)
  Enhance the way to get dubbo version (apache#11574)
  Bump protobuf-java from 3.21.12 to 3.22.0 (apache#11615)
  Bump maven-surefire-plugin from 3.0.0-M8 to 3.0.0-M9 (apache#11613)
  Bump micrometer-bom from 1.10.3 to 1.10.4 (apache#11611)
  Bump libthrift from 0.17.0 to 0.18.0 (apache#11614)
  Bump maven-failsafe-plugin from 3.0.0-M8 to 3.0.0-M9 (apache#11612)
  Bump reactor-core from 3.5.2 to 3.5.3 (apache#11610)
  Bump byte-buddy from 1.13.0 to 1.14.0 (apache#11609)
  Bump maven-javadoc-plugin from 3.4.1 to 3.5.0 (apache#11608)
  Bump micrometer-tracing-bom from 1.0.1 to 1.0.2 (apache#11607)
  3.2 consumer proxy invocation handler (apache#11108)
  Update DubboReference.java (apache#11621)
  Bump version to 3.1.8-SNAPSHOT
  Add Consumer Metrics (apache#11542)
  Backport of remove apache-rat-plugin. (apache#11523) (apache#11592)
  Update codecov config (apache#11582)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants