Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dubbo-security Jackson error #11622

Merged
merged 10 commits into from
Feb 23, 2023
Merged

Conversation

jojocodeX
Copy link
Contributor

(JSON序列化)[https://github.com//issues/11603]

  • 支持Jackson序列化器扩展配置
  • 代码格式化调整

Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jojocodeX jojocodeX changed the title Jackson序列化错误 dubbo-security Jackson error Feb 21, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #11622 (24c096c) into 3.2 (62509fb) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #11622      +/-   ##
============================================
- Coverage     69.75%   69.60%   -0.16%     
+ Complexity      105        2     -103     
============================================
  Files          1573     1383     -190     
  Lines         84223    60029   -24194     
  Branches      15012     8917    -6095     
============================================
- Hits          58750    41783   -16967     
+ Misses        20573    14104    -6469     
+ Partials       4900     4142     -758     
Impacted Files Coverage Δ
...e/dubbo/rpc/cluster/filter/FilterChainBuilder.java
...a/org/apache/dubbo/metrics/model/MethodMetric.java
...ava/org/apache/dubbo/metrics/model/MetricsKey.java
.../dubbo/metrics/model/sample/GaugeMetricSample.java
...pache/dubbo/metrics/model/sample/MetricSample.java
...o/metrics/collector/AggregateMetricsCollector.java
...metrics/collector/sample/MethodMetricsSampler.java
...org/apache/dubbo/metrics/filter/MetricsFilter.java
...ilter/AuthenticationExceptionTranslatorFilter.java
...lter/ContextHolderAuthenticationPrepareFilter.java
... and 2945 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jojocodeX jojocodeX requested a review from AlbumenJ February 21, 2023 06:41
Comment on lines 1 to 34
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.apache.dubbo.metrics.collector.stat;

import org.apache.dubbo.metrics.event.MetricsEvent;
import org.apache.dubbo.metrics.model.MethodMetric;
import org.apache.dubbo.rpc.Invocation;

import java.util.Map;
import java.util.concurrent.atomic.AtomicLong;

public interface MetricsStatHandler {
Map<MethodMetric, AtomicLong> get();

MetricsEvent increase(String applicationName, Invocation invocation);

MetricsEvent decrease(String applicationName, Invocation invocation);

MetricsEvent addApplication(String applicationName);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this class?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the code is undo

# Conflicts:
#	dubbo-plugin/dubbo-spring-security/src/main/java/org/apache/dubbo/spring/security/jackson/ObjectMapperCodecCustomer.java
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

45.3% 45.3% Coverage
0.0% 0.0% Duplication

@jojocodeX jojocodeX requested a review from AlbumenJ February 23, 2023 01:14
Copy link
Member

@AlbumenJ AlbumenJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlbumenJ AlbumenJ merged commit 638b193 into apache:3.2 Feb 23, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 23, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Feb 23, 2023
* origin/3.2: (32 commits)
  dubbo-security Jackson error (apache#11622)
  sync meter to spring boot management (apache#11630)
  Rest bugfix & optimization (apache#11617)
  Observability task: metadata center (apache#11593)
  Enhance the way to get dubbo version (apache#11574)
  Bump protobuf-java from 3.21.12 to 3.22.0 (apache#11615)
  Bump maven-surefire-plugin from 3.0.0-M8 to 3.0.0-M9 (apache#11613)
  Bump micrometer-bom from 1.10.3 to 1.10.4 (apache#11611)
  Bump libthrift from 0.17.0 to 0.18.0 (apache#11614)
  Bump maven-failsafe-plugin from 3.0.0-M8 to 3.0.0-M9 (apache#11612)
  Bump reactor-core from 3.5.2 to 3.5.3 (apache#11610)
  Bump byte-buddy from 1.13.0 to 1.14.0 (apache#11609)
  Bump maven-javadoc-plugin from 3.4.1 to 3.5.0 (apache#11608)
  Bump micrometer-tracing-bom from 1.0.1 to 1.0.2 (apache#11607)
  3.2 consumer proxy invocation handler (apache#11108)
  Update DubboReference.java (apache#11621)
  Bump version to 3.1.8-SNAPSHOT
  Add Consumer Metrics (apache#11542)
  Backport of remove apache-rat-plugin. (apache#11523) (apache#11592)
  Update codecov config (apache#11582)
  ...
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
@lizf2014
Copy link

(JSON序列化)[https://github.com//issues/11603]

  • 支持Jackson序列化器扩展配置
  • 代码格式化调整

你好,我也遇到了这个问题,在不升级 dubbo 版本的前提下,怎么解决这个问题呢?
dubbo version:3.2.0-beta.5
spring-security-oauth2-authorization-server:1.0.2

@AlbumenJ
Copy link
Member

升级到 3.2.4 看一下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants