Fix #11767, restore the original parameter pair instead of giving default value when doing URL.parse. #11781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.1 #11781 +/- ##
============================================
- Coverage 64.74% 64.73% -0.01%
Complexity 14 14
============================================
Files 1431 1431
Lines 60034 60034
Branches 8827 8827
============================================
- Hits 38867 38864 -3
+ Misses 17100 17098 -2
- Partials 4067 4072 +5
... and 17 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed! |
chickenlj
changed the title
mytang0
added a commit
to mytang0/dubbo
that referenced
this pull request
Mar 14, 2023
* origin/3.2: (25 commits) Bump bytebuddy.version from 1.14.1 to 1.14.2 (apache#11814) Dynamically generate native image config (apache#11795) Remove redundant synchronized (apache#11811) fix remove unused param (apache#11787) Bump bytebuddy.version from 1.14.0 to 1.14.1 (apache#11808) Reuse qos port for metrics (apache#11719) 🐛 fix thread pool metrics be gc recycle problem (apache#11793) Bump protobuf-java from 3.22.0 to 3.22.2 (apache#11802) Bump spring-security-bom from 5.8.1 to 5.8.2 (apache#11801) Bump byte-buddy from 1.14.0 to 1.14.1 (apache#11804) Cert npe bug fix (apache#11800) Fix uts Fix lock acquire blocked Fix hessian list Fix metrics publisher NPE Fix ut Fix bug apache#11767 (apache#11781) Fix uts Sync when destroy (apache#11783) Fix recreate client after destroy (apache#11780) ...
mytang0
added a commit
to mytang0/dubbo
that referenced
this pull request
Mar 14, 2023
* origin/3.2: (28 commits) Bump bytebuddy.version from 1.14.1 to 1.14.2 (apache#11814) Dynamically generate native image config (apache#11795) Remove redundant synchronized (apache#11811) fix remove unused param (apache#11787) Bump bytebuddy.version from 1.14.0 to 1.14.1 (apache#11808) Reuse qos port for metrics (apache#11719) 🐛 fix thread pool metrics be gc recycle problem (apache#11793) Bump protobuf-java from 3.22.0 to 3.22.2 (apache#11802) Bump spring-security-bom from 5.8.1 to 5.8.2 (apache#11801) Bump byte-buddy from 1.14.0 to 1.14.1 (apache#11804) Cert npe bug fix (apache#11800) Fix uts Fix lock acquire blocked Fix hessian list Fix metrics publisher NPE Fix ut Fix bug apache#11767 (apache#11781) Fix uts Sync when destroy (apache#11783) Fix recreate client after destroy (apache#11780) ...
lcb11
pushed a commit
to lcb11/dubbo
that referenced
this pull request
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When value has no value, make sure value is an empty string, rather than assigning the value of name to value
For key-value pair
key_name=, the generated URL parameter should be 'key_name=' rather thankey_name=key_ nameBrief changelog
Verifying this change
Checklist