Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant synchronized #11811

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

kang-hl
Copy link
Contributor

@kang-hl kang-hl commented Mar 13, 2023

What is the purpose of the change

Remove redundant synchronized

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@kang-hl
Copy link
Contributor Author

kang-hl commented Mar 13, 2023

init()方法的访问修饰符为protected,所以不能将其修改为非同步方法。

@AlbumenJ AlbumenJ merged commit e6ee608 into apache:3.2 Mar 13, 2023
mytang0 added a commit to mytang0/dubbo that referenced this pull request Mar 14, 2023
* origin/3.2: (25 commits)
  Bump bytebuddy.version from 1.14.1 to 1.14.2 (apache#11814)
  Dynamically generate native image config (apache#11795)
  Remove redundant synchronized (apache#11811)
  fix remove unused param (apache#11787)
  Bump bytebuddy.version from 1.14.0 to 1.14.1 (apache#11808)
  Reuse qos port for metrics (apache#11719)
  🐛 fix thread pool metrics be gc recycle problem (apache#11793)
  Bump protobuf-java from 3.22.0 to 3.22.2 (apache#11802)
  Bump spring-security-bom from 5.8.1 to 5.8.2 (apache#11801)
  Bump byte-buddy from 1.14.0 to 1.14.1 (apache#11804)
  Cert npe bug fix (apache#11800)
  Fix uts
  Fix lock acquire blocked
  Fix hessian list
  Fix metrics publisher NPE
  Fix ut
  Fix bug apache#11767 (apache#11781)
  Fix uts
  Sync when destroy (apache#11783)
  Fix recreate client after destroy (apache#11780)
  ...
mytang0 added a commit to mytang0/dubbo that referenced this pull request Mar 14, 2023
* origin/3.2: (28 commits)
  Bump bytebuddy.version from 1.14.1 to 1.14.2 (apache#11814)
  Dynamically generate native image config (apache#11795)
  Remove redundant synchronized (apache#11811)
  fix remove unused param (apache#11787)
  Bump bytebuddy.version from 1.14.0 to 1.14.1 (apache#11808)
  Reuse qos port for metrics (apache#11719)
  🐛 fix thread pool metrics be gc recycle problem (apache#11793)
  Bump protobuf-java from 3.22.0 to 3.22.2 (apache#11802)
  Bump spring-security-bom from 5.8.1 to 5.8.2 (apache#11801)
  Bump byte-buddy from 1.14.0 to 1.14.1 (apache#11804)
  Cert npe bug fix (apache#11800)
  Fix uts
  Fix lock acquire blocked
  Fix hessian list
  Fix metrics publisher NPE
  Fix ut
  Fix bug apache#11767 (apache#11781)
  Fix uts
  Sync when destroy (apache#11783)
  Fix recreate client after destroy (apache#11780)
  ...
lcb11 pushed a commit to lcb11/dubbo that referenced this pull request Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants