-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Issue 8516 on branch 2.7-native_image #8520
Conversation
by the way, is it ok to commit to the branch |
|
目前3.0是最新分支哈 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix ut.
also, this should be submitted to the master branch. By the way, help to see if this problem exists in the 3.0 branch please.
common/compiler/support/JdkCompiler.java:40:8: Unused import - java.nio.file.Files. [UnusedImports]
谢谢大佬,我试试!! |
thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch? |
Fix the bug of the 2.7 branch (that is master) first, and then check whether this problem also exists in the 3.0 branch. After this fix, also check whether the 2.6.x version also has this problem. |
I submit to master branch and 3.0 branch. could you please help me review? #8558 #8554 |
2.7-native_image这个分支本身单测就过不了啊 -。- |
|
What is the purpose of the change
fix #8516
Brief changelog
make the method
org.apache.dubbo.rpc.support.MockInvoker.getInvoker
mock in default way correctly.It was always get the same invoker which was the first one to mock.
Verifying this change
Checklist