Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 8516 on branch 2.7-native_image #8520

Closed
wants to merge 4 commits into from

Conversation

changfubai
Copy link
Contributor

@changfubai changfubai commented Aug 16, 2021

What is the purpose of the change

fix #8516

Brief changelog

make the method org.apache.dubbo.rpc.support.MockInvoker.getInvoker mock in default way correctly.
It was always get the same invoker which was the first one to mock.

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@changfubai
Copy link
Contributor Author

changfubai commented Aug 16, 2021

by the way, is it ok to commit to the branch apache:2.7-native_image ?

@wangchengming666
Copy link
Member

wangchengming666 commented Aug 18, 2021

image
@changfubai 帮你看了一下,应该是这个问题。你可以去guide上找一个code style,然后本地代码格式化一下试试哈 https://github.com/apache/dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml

@wangchengming666
Copy link
Member

by the way, is it ok to commit to the branch apache:2.7-native_image ?

目前3.0是最新分支哈

@24kpure
Copy link
Contributor

24kpure commented Aug 19, 2021

What is the purpose of the change

fix #8513
fix #8516

Copy link
Contributor

@xiaoheng1 xiaoheng1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix ut.

also, this should be submitted to the master branch. By the way, help to see if this problem exists in the 3.0 branch please.

common/compiler/support/JdkCompiler.java:40:8: Unused import - java.nio.file.Files. [UnusedImports]

@changfubai
Copy link
Contributor Author

changfubai commented Aug 19, 2021

image
@changfubai 帮你看了一下,应该是这个问题。你可以去guide上找一个code style,然后本地代码格式化一下试试哈 https://github.com/apache/dubbo/blob/master/codestyle/dubbo_codestyle_for_idea.xml。

谢谢大佬,我试试!!

@changfubai
Copy link
Contributor Author

What is the purpose of the change

fix #8513
fix #8516

sorry, that was a slip of the pen. just fixed #8516

@changfubai
Copy link
Contributor Author

please fix ut.

also, this should be submitted to the master branch. By the way, help to see if this problem exists in the 3.0 branch please.

common/compiler/support/JdkCompiler.java:40:8: Unused import - java.nio.file.Files. [UnusedImports]

thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch?

@changfubai changfubai mentioned this pull request Aug 19, 2021
@xiaoheng1
Copy link
Contributor

thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch?

Fix the bug of the 2.7 branch (that is master) first, and then check whether this problem also exists in the 3.0 branch. After this fix, also check whether the 2.6.x version also has this problem.

@changfubai changfubai changed the title fix Issue 8516 fix Issue 8516 on branch 2.7-native_image Aug 20, 2021
@changfubai
Copy link
Contributor Author

changfubai commented Aug 20, 2021

thanks!! I'll try it. By the way, fix bug in master branch, then when to fix in old branch?

Fix the bug of the 2.7 branch (that is master) first, and then check whether this problem also exists in the 3.0 branch. After this fix, also check whether the 2.6.x version also has this problem.

I submit to master branch and 3.0 branch. could you please help me review? #8558 #8554
by the way, should i submit this commit to all the branches if this bug exist on the all?

@changfubai
Copy link
Contributor Author

2.7-native_image这个分支本身单测就过不了啊 -。-

@AlbumenJ AlbumenJ changed the base branch from 2.7-native_image to master August 23, 2021 05:27
@AlbumenJ AlbumenJ changed the base branch from master to 2.7-native_image August 23, 2021 05:27
@AlbumenJ
Copy link
Member

2.7-native_image branch is deprecated. Those changes have been merge into master(2.7.x) and 3.0 branch. Please check if our mainline branch have the same problem.

@AlbumenJ AlbumenJ closed this Aug 23, 2021
@changfubai changfubai deleted the issue-8516 branch September 9, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants