Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Issue 8516 on branch 3.0: fix mock:true configuration. #8558

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

changfubai
Copy link
Contributor

same as #8520

@changfubai changfubai changed the title fix issue-8516 on branch 3.0 fix Issue 8516 on branch 3.0 Aug 20, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

Merging #8558 (8ea3304) into 3.0 (5630a3c) will increase coverage by 0.04%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8558      +/-   ##
============================================
+ Coverage     62.93%   62.98%   +0.04%     
+ Complexity      313      311       -2     
============================================
  Files          1117     1117              
  Lines         46735    46736       +1     
  Branches       7032     7033       +1     
============================================
+ Hits          29414    29435      +21     
+ Misses        14063    14041      -22     
- Partials       3258     3260       +2     
Impacted Files Coverage Δ
...java/org/apache/dubbo/rpc/support/MockInvoker.java 84.42% <66.66%> (-0.70%) ⬇️
...e/dubbo/remoting/transport/netty/NettyChannel.java 54.54% <0.00%> (-5.69%) ⬇️
...apache/dubbo/common/extension/ExtensionLoader.java 79.20% <0.00%> (ø)
...vent/listener/ServiceInstancesChangedListener.java 78.10% <0.00%> (+0.49%) ⬆️
...he/dubbo/registry/multicast/MulticastRegistry.java 67.59% <0.00%> (+0.92%) ⬆️
...ting/zookeeper/curator/CuratorZookeeperClient.java 72.41% <0.00%> (+0.98%) ⬆️
.../dubbo/remoting/transport/netty4/NettyChannel.java 66.33% <0.00%> (+1.98%) ⬆️
...pache/dubbo/registry/support/AbstractRegistry.java 79.56% <0.00%> (+2.91%) ⬆️
.../apache/dubbo/remoting/transport/AbstractPeer.java 63.04% <0.00%> (+4.34%) ⬆️
...dubbo/remoting/exchange/support/DefaultFuture.java 93.85% <0.00%> (+4.38%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5630a3c...8ea3304. Read the comment docs.

@BurningCN
Copy link
Member

The name of pr should be more specific, such as what problem is fixed

@changfubai
Copy link
Contributor Author

The name of pr should be more specific, such as what problem is fixed

ok.thanks

@changfubai changfubai changed the title fix Issue 8516 on branch 3.0 fix Issue 8516 on branch 3.0: fix mock:true configuration. Aug 20, 2021
@AlbumenJ AlbumenJ merged commit 72e1f6e into apache:3.0 Aug 23, 2021
@changfubai changfubai deleted the issue-8516-3.0 branch September 9, 2021 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants