Merge pull request #17861 from apache/fix/hashmap

fix(data): change deprecated `map.data.hasOwnProperty` to `map.hasKey`

package.json

@@ -64,7 +64,7 @@
   },
   "dependencies": {
     "tslib": "2.3.0",
-    "zrender": "5.4.0"
+    "zrender": "npm:zrender-nightly@^5.4.1-dev.20221104"
   },
   "devDependencies": {
     "@babel/code-frame": "7.10.4",

src/data/helper/createDimensions.ts

@@ -114,7 +114,7 @@ export default function prepareSeriesDataSchema(
     const resultList: SeriesDimensionDefine[] = [];
     const dimCount = getDimCount(source, sysDims, dimsDef, opt.dimensionsCount);
 
-    // Try to ignore unsed dimensions if sharing a high dimension datastore
+    // Try to ignore unused dimensions if sharing a high dimension datastore
     // 30 is an experience value.
     const omitUnusedDimensions = opt.canOmitUnusedDimensions && shouldOmitUnusedDimensions(dimCount);
 
@@ -188,7 +188,7 @@ export default function prepareSeriesDataSchema(
         });
     });
 
-    // Apply templetes and default order from `sysDims`.
+    // Apply templates and default order from `sysDims`.
     let availDimIdx = 0;
     each(sysDims, function (sysDimItemRaw) {
         let coordDim: DimensionName;
@@ -368,7 +368,7 @@ function removeDuplication(result: SeriesDimensionDefine[]) {
 // But
 // (1) custom series should be considered. where other dims
 // may be visited.
-// (2) sometimes user need to calcualte bubble size or use visualMap
+// (2) sometimes user need to calculate bubble size or use visualMap
 // on other dimensions besides coordSys needed.
 // So, dims that is not used by system, should be shared in data store?
 function getDimCount(
@@ -399,10 +399,9 @@ function genCoordDimName(
     map: HashMap<unknown, DimensionName>,
     fromZero: boolean
 ) {
-    const mapData = map.data;
-    if (fromZero || mapData.hasOwnProperty(name)) {
+    if (fromZero || map.hasKey(name)) {
         let i = 0;
-        while (mapData.hasOwnProperty(name + i)) {
+        while (map.hasKey(name + i)) {
             i++;
         }
         name += i;