Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): change deprecated map.data.hasOwnProperty to map.hasKey #17861

Merged
merged 2 commits into from
Nov 6, 2022

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Nov 2, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

ecomfe/zrender#966 has refactored the HashMap, which prefers the native built-in Map. It causes the HashMap.data.hasOwnProperty to be not working. So this PR is to change it to map.hasKey.

Fixed issues

Fix failed unit test test/ut/spec/data/createDimensions.test.ts

Failed information: https://github.com/apache/echarts/actions/runs/3368150373/jobs/5586364387

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

Related test cases or examples to use the new APIs

Please refer to test/ut/spec/data/createDimensions.test.ts

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Nov 2, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

This PR depends on ZRender changes. Please update the ZRender dependency to the latest nightly version including this change, which takes place everyday at 8:00 UTC (16:00 Beijing Time).
You can use npm i zrender@npm:zrender-nightly@dev to update package.json.
If you have any question about this, please leave a comment and we will give you extra help on this.

@pissang pissang merged commit 273f3ed into master Nov 6, 2022
@echarts-bot
Copy link

echarts-bot bot commented Nov 6, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix/hashmap branch November 6, 2022 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants