[ISSUE #4096] InterruptedExceptions should never be ignored in the code.[EtcdMetaService] #4636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ioned in the solution,by restoring interrupted state.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the Apache EventMesh community!!
This is your first PR in our project. We're very excited to have you onboard contributing. Your contributions are greatly appreciated!
Please make sure that the changes are covered by tests.
We will be here shortly.
Let us know if you need any help!
Want to get closer to the community?
| WeChat Assistant | WeChat Public Account | Slack |
|---|---|---|
 |
 |
Join Slack Chat |
Mailing Lists:
| Name | Description | Subscribe | Unsubscribe | Archive |
|---|---|---|---|---|
| Users | User support and questions mailing list | Subscribe | Unsubscribe | Mail Archives |
| Development | Development related discussions | Subscribe | Unsubscribe | Mail Archives |
| Commits | All commits to repositories | Subscribe | Unsubscribe | Mail Archives |
| Issues | Issues or PRs comments and reviews | Subscribe | Unsubscribe | Mail Archives |
Closed
2 tasks
pandaapo
approved these changes
Dec 11, 2023
pandaapo
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #4636 +/- ##
============================================
- Coverage 17.28% 17.27% -0.01%
Complexity 1741 1741
============================================
Files 792 792
Lines 29697 29703 +6
Branches 2567 2567
============================================
Hits 5132 5132
- Misses 24090 24096 +6
Partials 475 475 ☔ View full report in Codecov by Sentry. |
harshithasudhakar
approved these changes
Dec 11, 2023
HarshSawarkar
deleted the
4096-EtcdMetaService-InterruptedExceptions-should-never-be-ignored-in-the-code
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4096 .
Motivation
Earlier InterruptedExceptions were being being ignored as it were only being logged.
Modifications
Rewrite the catch blocks by restoring interrupted states through the invocation of Thread.interrupt().
Documentation