[ISSUE #4635] Implement the function of file source connector #4640
Conversation
…ioned in the solution,by restoring interrupted state.
HarshSawarkar
deleted the
4635-Implement-the-function-of-File-Source-Connector
branch
HarshSawarkar
restored the
4635-Implement-the-function-of-File-Source-Connector
branch
harshithasudhakar
changed the title
|
@HarshSawarkar Please fix the checkstyle errors. |
|
@HarshSawarkar I have a general question to increase my understanding of the project. I want to know why there was a need to change the EtcdMetaService and how it is related to the FileSourceConnector. |
There is no relation between these two classes.EtcdMetaService class was appended by mistake. |
…entmesh/meta/etcd/service/EtcdMetaService.java
|
@HarshSawarkar cool bro. :) 😎 But why that file is being shown as deleted now? It should not be present entirely in your commit. |
I don't know I tried to roll back changes but the file remain intacted so I deleted it. |
|
You can try re-uploading the file from the latest master branch to your branch
|
It's already marked as completed in 'eventmesh-connectors/README.md'.Here's the screenshot for reference |
| return null; | ||
| List<ConnectRecord> connectRecords = new ArrayList<>(); | ||
| try { | ||
| BufferedReader bufferedReader = new BufferedReader(new InputStreamReader(inputStream, StandardCharsets.UTF_8)); |
There was a problem hiding this comment.
Can BufferedReader object be set as a global variable? Additionally, in your current code, BufferedReader has a memory leak problem.
| @@ -45,7 +63,8 @@ public Class<? extends Config> configClass() { | |||
| public void init(Config config) throws Exception { | |||
| // init config for hdfs source connector | |||
| this.sourceConfig = (FileSourceConfig) config; | |||
|
|
|||
| this.filePath = buildFilePath(); | |||
| this.fileName = buildFileName(); | |||
There was a problem hiding this comment.
Could the file name and file path be directly configured in the configuration file? Additionally, could unnecessary configurations in the configuration file be removed?
@HarshSawarkar @VishalMCF You should create a development branch based on the latest master branch that is consistent with the source code. |
Fixes #4635
Motivation
File source connector class methods were not implemented.
Modifications
Successfully implemented start(), stop(), poll() methods of file source connector class.
Documentation