FINERACT-2023: Improve contributor's guide #3765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinav7sinha
force-pushed
the
FINERACT-2023/first-time-contributors-guide
branch
5 times, most recently
from
b7ad988
to
16f38ac
Compare
abhinav7sinha
force-pushed
the
FINERACT-2023/first-time-contributors-guide
branch
from
16f38ac
to
81f53db
Compare
6 tasks
jdailey
reviewed
Mar 12, 2024
|
|
||
| * Browse existing link:https://issues.apache.org/jira/browse/FINERACT-2055?jql=project%20%3D%20FINERACT%20ORDER%20BY%20created%20DESC[issues] | ||
| ** Filter by tags - "volunteer", "gsoc", "new contributor", etc. | ||
| * Browse link:https://mifosforge.jira.com/wiki/spaces/RES/pages/3532095546/Google+Summer+of+Code+2024+Ideas[GSoC projects] |
There was a problem hiding this comment.
We cannot point to an external project
jdailey
reviewed
Mar 12, 2024
| @@ -0,0 +1,3 @@ | |||
| = VIDEO DEMONSTRATION | |||
|
|
|||
| Apache Fineract / Mifos X Demo (November 2016) - <https://www.youtube.com/watch?v=h61g9TptMBo> | |||
There was a problem hiding this comment.
This is really old. Let's delete or create a new one. I think it should be a demo of the APIs
There was a problem hiding this comment.
@jdailey Done.
jdailey
reviewed
Mar 12, 2024
abhinav7sinha
force-pushed
the
FINERACT-2023/first-time-contributors-guide
branch
from
6be8a8e
to
d34fcb5
Compare
abhinav7sinha
force-pushed
the
FINERACT-2023/first-time-contributors-guide
branch
from
d34fcb5
to
79d71e9
Compare
agreed. I've made the changes now |
|
@abhinav7sinha Please fix the conflicts (rebase your PR) and squash the commits! |
|
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days. |
|
Is this stale? What changes are needed to accept this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated Apache Fineract JIRA ticket.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.