Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken links in README file on Github #3766

Closed

Conversation

HarimbolaSantatra
Copy link

@HarimbolaSantatra HarimbolaSantatra commented Feb 25, 2024

Description

This pull request fix more broken links in the README file in addition to the one made in #3686.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Write the commit message as per https://github.com/apache/fineract/#pull-requests

  • Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.

  • Create/update unit or integration tests for verifying the changes made.

  • Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.

  • Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes

  • Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)

FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.

@Zeyad2003
Copy link
Contributor

Hi @HarimbolaSantatra

Please refer to the CONTRIBUTING.md.
You need to mention the Jira ticket in your PR to be reviewed and track the changes.

Note

Follow up with one of the commiters to make sure your changes can be applied, as I saw this PR #3765 that modified the README too

Regards!

@vidakovic
Copy link
Contributor

@HarimbolaSantatra please follow the conventions concerning formatting the pull request title ("FINERACT-1234: Title of the JIRA ticket")

@vidakovic vidakovic closed this Mar 10, 2024
@vidakovic vidakovic reopened this Mar 10, 2024
@vidakovic
Copy link
Contributor

@HarimbolaSantatra accidentally closed the PR... re-opened it.

@adamsaghy
Copy link
Contributor

@HarimbolaSantatra Please follow the conventions on how to format the pull request title ("FINERACT-1234: Title of the JIRA ticket")

Same applies for the commit message as well

Copy link

github-actions bot commented May 4, 2024

This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.

@github-actions github-actions bot added the stale label May 4, 2024
@HarimbolaSantatra HarimbolaSantatra changed the title fix broken links in README.md FINERACT-2088: Broken links in README file on Github May 28, 2024
@HarimbolaSantatra HarimbolaSantatra deleted the readme-link branch May 28, 2024 18:39
@HarimbolaSantatra HarimbolaSantatra changed the title FINERACT-2088: Broken links in README file on Github broken links in README file on Github May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants