Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#397 Add authHeader callback option #398

Merged
merged 2 commits into from
Jan 24, 2024

Conversation

EandrewJones
Copy link
Contributor

Closes #397

Changes

  • adds registerAuthCallback function following strategy pattern as discussed in issue
  • adds test suite for new callback pattern

@Jyyjy
Copy link
Contributor

Jyyjy commented Jan 24, 2024

Please change the target branch to test, and include the build changes. Otherwise looks good, and an extra thank you for including such comprehensive tests.

@EandrewJones EandrewJones changed the base branch from master to test January 24, 2024 19:46
@EandrewJones
Copy link
Contributor Author

@Jyyjy

Please change the target branch to test, and include the build changes. Otherwise looks good, and an extra thank you for including such comprehensive tests.

Both done.

@Jyyjy Jyyjy merged commit 8b07420 into apache:test Jan 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add auth header callback option for UserALE
2 participants