Allow users to add custom headers #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #400
Changes
Follows identical pattern to #398 to allow users to statically add additional headers to the POST request or dynamically generate new headers on every request.
Things to consider
Given how this behavior is a superset of the feature introduced #398, we could refactor and merge the two. But this would be a breaking change since it would mean deprecating the
config.authfield in favor of a more genericconfig.headersfield.My preference is to keep both and leave them separate. Users could opt to use the headers callback to cover the Auth case as well, which may be preferred if they need to define the auth headers + some others. For users that only need to add auth headers, they could use the functionality added in #398.