Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-24273][kubernetes] Relocate io.fabric8 dependency. #17262

Closed
wants to merge 1 commit into from

Conversation

dmvk
Copy link
Member

@dmvk dmvk commented Sep 13, 2021

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 8ce1ce0 (Mon Sep 13 12:42:41 UTC 2021)

Warnings:

  • 1 pom.xml files were touched: Check for build and licensing issues.
  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 13, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding shading for io.fabric8 @dmvk. I think the change itself looks good. However, we have a problem because shading of resource files can fail if no clean is executed. See elastic/apm-agent-java#961. That's why the test_ci misc profile fails.

I do see potential solutions:

  1. Run clean for flink-kubernetes when running mvn verify.
  2. Add io.fabric8.* dependencies to flink-shaded and use these dependencies directly.

Option 2) is probably more work but probably also the cleaner solution.

cc @zentol.

@tillrohrmann
Copy link
Contributor

I've tried bumping the maven-shade-plugin version to 3.2.4 but it suffered from the same problem.

@tillrohrmann
Copy link
Contributor

@dmvk it would also be good to understand where a dependency conflict arises with the unrelocated io.fabric8.* dependencies.

@rmetzger
Copy link
Contributor

It seems that the issue in the maven shade plugin has been fixed: apache/maven-shade-plugin#150 / https://issues.apache.org/jira/browse/MSHADE-425 in 3.4.0. We are still on 3.2.4.
I will try and see if we can easily bump the version.

@rmetzger
Copy link
Contributor

Closing as a duplicate.

@rmetzger rmetzger closed this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants