-
Notifications
You must be signed in to change notification settings - Fork 13.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-24273][kubernetes] Relocate io.fabric8 dependency. #17262
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 8ce1ce0 (Mon Sep 13 12:42:41 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding shading for io.fabric8
@dmvk. I think the change itself looks good. However, we have a problem because shading of resource files can fail if no clean
is executed. See elastic/apm-agent-java#961. That's why the test_ci misc
profile fails.
I do see potential solutions:
- Run
clean
forflink-kubernetes
when runningmvn verify
. - Add
io.fabric8.*
dependencies toflink-shaded
and use these dependencies directly.
Option 2) is probably more work but probably also the cleaner solution.
cc @zentol.
I've tried bumping the |
@dmvk it would also be good to understand where a dependency conflict arises with the unrelocated |
It seems that the issue in the maven shade plugin has been fixed: apache/maven-shade-plugin#150 / https://issues.apache.org/jira/browse/MSHADE-425 in 3.4.0. We are still on 3.2.4. |
Closing as a duplicate. |
https://issues.apache.org/jira/browse/FLINK-24273