[MSHADE-425] Relocate services name before add to serviceEntries

[tisonkun]

Signed-off-by: tison wander4096@gmail.com

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MSHADE-XXX] - Fixes bug in ApproximateQuantiles,
  where you replace MSHADE-XXX with the appropriate JIRA issue. Best practice
  is to use the JIRA issue title in the pull request title and in the first line of the
  commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[tisonkun]

cc @khmarbaise @rmannibucau

[slawekjaranowski]

@tisonkun Thanks for your PR.
We need a unit test to be sure that next change don't break it.

[tisonkun]

@slawekjaranowski Yes. I ever thought of this. Let me try to dig out how to add one. Or could you show me some related tests.

[slawekjaranowski]

I don't investigate deeper - only mention about missing test

[slawekjaranowski]

There is a https://github.com/apache/maven-shade-plugin/blob/master/src/test/java/org/apache/maven/plugins/shade/resource/ServiceResourceTransformerTest.java

maybe tests don't cover all path - you change something in class but tests still works without change

[tisonkun]

@slawekjaranowski Yes. I would say this patch is simple enough to be correct. But I'm glad to add some tests to prevent regressions.

[tisonkun]

@slawekjaranowski Added at d29c633. Also verify locally that without this patch the test failed.

[tisonkun]

@rmannibucau @slawekjaranowski do we still wait for other conditions to merge this patch?

[rmannibucau]

@tisonkun on my side I was just waiting for @slawekjaranowski to ack (or merge, no issue) but otherwise no blocker for this pr for me

[slawekjaranowski]

you can squash to one final commit and will be ok for me also.

[tisonkun]

Squashed.

Though, you can use GitHub "Squash and Commit" button to perform the squash, so that we don't need one more CI turn.

[tisonkun]

@rmannibucau @slawekjaranowski I may be a bit in a hurry but I'd like to know whether/when we can have a release for this fix. It resolves one or several downstream use cases and I'm happy to upgrade for this fix.

It's not a request, though.

[rmannibucau]

@tisonkun guess a mail on the mailing list can make people more aware of it (at least the ones with the full karma to do it ;))

[slawekjaranowski]

drop a line on dev list is good idea
@rmannibucau each committer has enough karma/privileges for releases

[rmannibucau]

@slawekjaranowski nop, only a PMC can achieve it (for goods) so if a commiter can start it he can't end it so always better to ensure some PMC is there to handle all the needed steps before starting by XP.

[slawekjaranowski]

if you wish we can discuss on dev list
look last pending release of m-pmd-p

[tisonkun]

Thanks! I'm subscribing dev@maven.apache.org mailing list now.

m-pmd-p

Out of curiosity, what does this stand for?

[slawekjaranowski]

m-pmd-p -> maven-pmd-plugin 😄