update shade plugin version #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roasher
requested review from
pierredebelen,
davidharte-gs,
Yasirmod17,
aormerod-gs,
gs-ssh16,
epsstan,
kevin-m-knight-gs,
rafaelbey,
aziemchawdhary-gs,
elopezcastro and
MauricioUyaguari
as code owners
…duced one. Need this cause server would be used as a dependency
rafaelbey
approved these changes
Dec 27, 2022
hausea
pushed a commit
to hausea/legend-engine
that referenced
this pull request
Feb 8, 2023
* update shade plugin version * update shade plugin configs * update shade plugin configs * disable reduced pom creation to end original pom in repo istead of reduced one. Need this cause server would be used as a dependency * rollback autoformat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Plugin update
What does this PR do / why is it needed ?
This plugin updates maven-shade-plugin up to 3.4.1 version.
Shade plugin update needed to be able to add submodules with relocation, like #1256
In version that we use now, if relocation is triggered, build would fail if there is no "clean" command prior to shade goal.
And this is the case now:
legend-engine/.github/workflows/build.yml
Line 79 in b1887b5
legend-engine/.github/workflows/build.yml
Line 80 in b1887b5
In new plugin version this bug is fixed:
elastic/apm-agent-java#961
apache/maven-shade-plugin#150
Does this PR introduce a user-facing change?
No