generated from finos/software-project-blueprint
-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spanner enable #1256
Merged
Merged
Spanner enable #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roasher
requested review from
rafaelbey,
aziemchawdhary-gs,
elopezcastro and
MauricioUyaguari
as code owners
December 16, 2022 11:27
ghost
approved these changes
Dec 16, 2022
And there is no "clean" on second one. First build runs successfully, second fails.
|
# Conflicts: # legend-engine-server/pom.xml
…duced one. Need this cause server would be used as a dependency
davidharte-gs
approved these changes
Dec 27, 2022
hausea
pushed a commit
to hausea/legend-engine
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Enabling spanner connector functionality
What does this PR do / why is it needed ?
After this change spanner would be legal db for studio projects
Other notes for reviewers:
this PR contains shading google spanner jdbc and relocation of all it's compiled classes to custom package, so there would be no dependency conflicts with other part of platform
copy of #1135 with java doc jar sonatype problem fix
Does this PR introduce a user-facing change?
No, just adding new db type among others