Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanner enable #1256

Merged
merged 65 commits into from
Dec 28, 2022
Merged

Spanner enable #1256

merged 65 commits into from
Dec 28, 2022

Conversation

roasher
Copy link
Contributor

@roasher roasher commented Dec 16, 2022

What type of PR is this?

Enabling spanner connector functionality

What does this PR do / why is it needed ?

After this change spanner would be legal db for studio projects

Other notes for reviewers:

this PR contains shading google spanner jdbc and relocation of all it's compiled classes to custom package, so there would be no dependency conflicts with other part of platform

copy of #1135 with java doc jar sonatype problem fix

Does this PR introduce a user-facing change?

No, just adding new db type among others

@github-actions
Copy link

github-actions bot commented Dec 16, 2022

Test Results

   350 files  ±0     350 suites  ±0   1h 18m 19s ⏱️ + 5m 33s
8 161 tests +1  7 953 ✔️ +1  208 💤 ±0  0 ±0 
9 574 runs  +1  9 341 ✔️ +1  233 💤 ±0  0 ±0 

Results for commit bf55ae7. ± Comparison against base commit b4d291f.

♻️ This comment has been updated with latest results.

@roasher
Copy link
Contributor Author

roasher commented Dec 17, 2022

@gs-ssh16

  1. Problem with https://github.com/finos/legend-engine/actions/runs/3710941855/jobs/6290890928 is due to fact that we run 2 maven tasks instead of one:
mvn -B -e install -DskipTests=true
mvn -B -e javadoc:javadoc deploy -DargLine="-Xmx2200m" -P docker-snapshot

And there is no "clean" on second one. First build runs successfully, second fails.
This is due to shade plugin bug: elastic/apm-agent-java#961. This was fixed in September, so I did plugin update and checked in my local env and it ok now.

  1. Release build problem https://github.com/finos/legend-engine/actions/runs/3711380363/jobs/6291747703 is fixed via adding blank JavaPlaceholder.java file. Although it looks like a hack, but I couldn't find much better solution and it seems that this approach is already used by Pierre: https://github.com/finos/legend-pure/blob/4327c2a3b8dacabba73b3c80693760036ff55675/legend-pure-m3-platform/src/main/java/org/finos/legend/pure/m3/platform/JavaPlaceholder.java#L17

@gs-ssh16 gs-ssh16 merged commit d46df89 into finos:master Dec 28, 2022
hausea pushed a commit to hausea/legend-engine that referenced this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants