[#5548] feat(core): add fileset pre event to Gravitino event #5652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add corresponding `FilesetPreEvent` 2. generate pre-event in `FilesetEventDispatcher`
- Fix coding style
TungYuChiang
changed the title
FANNG1
reviewed
Nov 24, 2024
| import org.apache.gravitino.annotation.DeveloperApi; | ||
| import org.apache.gravitino.file.FilesetChange; | ||
|
|
||
| @DeveloperApi |
There was a problem hiding this comment.
Could you add java doc for the class?
|
LGTM except one minor comment, @TungYuChiang could you fix it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add fileset pre event to Gravitino event
Why are the changes needed?
Fix: #5548
Does this PR introduce any user-facing change?
no
How was this patch tested?
added unit test