-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#5548] feat(core): add fileset pre event to Gravitino event #5652
Open
TungYuChiang
wants to merge
2
commits into
apache:main
Choose a base branch
from
TungYuChiang:feature/event
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
core/src/main/java/org/apache/gravitino/listener/api/event/AlterFilesetPreEvent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.gravitino.listener.api.event; | ||
|
||
import org.apache.gravitino.NameIdentifier; | ||
import org.apache.gravitino.annotation.DeveloperApi; | ||
import org.apache.gravitino.file.FilesetChange; | ||
|
||
@DeveloperApi | ||
public final class AlterFilesetPreEvent extends FilesetPreEvent { | ||
private final FilesetChange[] filesetChanges; | ||
|
||
public AlterFilesetPreEvent( | ||
String user, NameIdentifier identifier, FilesetChange[] filesetChanges) { | ||
super(user, identifier); | ||
this.filesetChanges = filesetChanges; | ||
} | ||
|
||
/** | ||
* Retrieves the specific changes that were made to the fileset during the alteration process. | ||
* | ||
* @return An array of {@link FilesetChange} objects detailing each modification applied to the | ||
* fileset. | ||
*/ | ||
public FilesetChange[] filesetChanges() { | ||
return filesetChanges; | ||
} | ||
|
||
/** | ||
* Returns the type of operation. | ||
* | ||
* @return the operation type. | ||
*/ | ||
@Override | ||
public OperationType operationType() { | ||
return OperationType.ALTER_FILESET; | ||
} | ||
} |
56 changes: 56 additions & 0 deletions
56
core/src/main/java/org/apache/gravitino/listener/api/event/CreateFilesetPreEvent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.gravitino.listener.api.event; | ||
|
||
import org.apache.gravitino.NameIdentifier; | ||
import org.apache.gravitino.annotation.DeveloperApi; | ||
import org.apache.gravitino.listener.api.info.FilesetInfo; | ||
|
||
/** Represents an event triggered before creating a fileset. */ | ||
@DeveloperApi | ||
public class CreateFilesetPreEvent extends FilesetPreEvent { | ||
private final FilesetInfo createFilesetRequest; | ||
|
||
public CreateFilesetPreEvent( | ||
String user, NameIdentifier identifier, FilesetInfo createFilesetRequest) { | ||
super(user, identifier); | ||
this.createFilesetRequest = createFilesetRequest; | ||
} | ||
|
||
/** | ||
* Retrieves the create fileset request. | ||
* | ||
* @return A {@link FilesetInfo} instance encapsulating the comprehensive details of create | ||
* fileset request. | ||
*/ | ||
public FilesetInfo createFilesetRequest() { | ||
return createFilesetRequest; | ||
} | ||
|
||
/** | ||
* Returns the type of operation. | ||
* | ||
* @return the operation type. | ||
*/ | ||
@Override | ||
public OperationType operationType() { | ||
return OperationType.CREATE_FILESET; | ||
} | ||
} |
41 changes: 41 additions & 0 deletions
41
core/src/main/java/org/apache/gravitino/listener/api/event/DropFilesetPreEvent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.gravitino.listener.api.event; | ||
|
||
import org.apache.gravitino.NameIdentifier; | ||
import org.apache.gravitino.annotation.DeveloperApi; | ||
|
||
/** Represents an event that is triggered before dropping a fileset. */ | ||
@DeveloperApi | ||
public final class DropFilesetPreEvent extends FilesetPreEvent { | ||
public DropFilesetPreEvent(String user, NameIdentifier identifier) { | ||
super(user, identifier); | ||
} | ||
|
||
/** | ||
* Returns the type of operation. | ||
* | ||
* @return the operation type. | ||
*/ | ||
@Override | ||
public OperationType operationType() { | ||
return OperationType.DROP_FILESET; | ||
} | ||
} |
31 changes: 31 additions & 0 deletions
31
core/src/main/java/org/apache/gravitino/listener/api/event/FilesetPreEvent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.gravitino.listener.api.event; | ||
|
||
import org.apache.gravitino.NameIdentifier; | ||
import org.apache.gravitino.annotation.DeveloperApi; | ||
|
||
/** Represents a pre-event for fileset operations. */ | ||
@DeveloperApi | ||
public abstract class FilesetPreEvent extends PreEvent { | ||
protected FilesetPreEvent(String user, NameIdentifier identifier) { | ||
super(user, identifier); | ||
} | ||
} |
60 changes: 60 additions & 0 deletions
60
core/src/main/java/org/apache/gravitino/listener/api/event/GetFileLocationPreEvent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,60 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.gravitino.listener.api.event; | ||
|
||
import org.apache.gravitino.NameIdentifier; | ||
import org.apache.gravitino.annotation.DeveloperApi; | ||
|
||
/** Represents an event that is triggered before attempting to get an actual file location. */ | ||
@DeveloperApi | ||
public final class GetFileLocationPreEvent extends FilesetPreEvent { | ||
private final String subPath; | ||
|
||
/** | ||
* Constructs a new {@code GetFileLocationPreEvent}, recording the intent to get a file location. | ||
* | ||
* @param user The user who initiated the get file location operation. | ||
* @param identifier The identifier of the file location to be accessed. | ||
* @param subPath The accessing sub path of the get file location operation. | ||
*/ | ||
public GetFileLocationPreEvent(String user, NameIdentifier identifier, String subPath) { | ||
super(user, identifier); | ||
this.subPath = subPath; | ||
} | ||
|
||
/** | ||
* Get the accessing sub path of the get file location operation. | ||
* | ||
* @return The accessing sub path. | ||
*/ | ||
public String subPath() { | ||
return subPath; | ||
} | ||
|
||
/** | ||
* Returns the type of operation. | ||
* | ||
* @return the operation type. | ||
*/ | ||
@Override | ||
public OperationType operationType() { | ||
return OperationType.GET_FILESET_LOCATION; | ||
} | ||
} |
54 changes: 54 additions & 0 deletions
54
core/src/main/java/org/apache/gravitino/listener/api/event/ListFilesetPreEvent.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one | ||
* or more contributor license agreements. See the NOTICE file | ||
* distributed with this work for additional information | ||
* regarding copyright ownership. The ASF licenses this file | ||
* to you under the Apache License, Version 2.0 (the | ||
* "License"); you may not use this file except in compliance | ||
* with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
package org.apache.gravitino.listener.api.event; | ||
|
||
import org.apache.gravitino.NameIdentifier; | ||
import org.apache.gravitino.Namespace; | ||
import org.apache.gravitino.annotation.DeveloperApi; | ||
|
||
/** Represents an event that is triggered before listing of filesets within a namespace. */ | ||
@DeveloperApi | ||
public final class ListFilesetPreEvent extends FilesetPreEvent { | ||
private final Namespace namespace; | ||
|
||
public ListFilesetPreEvent(String user, Namespace namespace) { | ||
super(user, NameIdentifier.of(namespace.levels())); | ||
this.namespace = namespace; | ||
} | ||
|
||
/** | ||
* Provides the namespace associated with this event. | ||
* | ||
* @return A {@link Namespace} instance from which filesets were listed. | ||
*/ | ||
public Namespace namespace() { | ||
return namespace; | ||
} | ||
|
||
/** | ||
* Returns the type of operation. | ||
* | ||
* @return the operation type. | ||
*/ | ||
@Override | ||
public OperationType operationType() { | ||
return OperationType.LIST_FILESET; | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add java doc for the class?