[collector] fix the wrong condition for checking the response #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crossoverJie
reviewed
Jun 7, 2024
| @@ -133,7 +133,7 @@ public void collect(CollectRep.MetricsData.Builder builder, | |||
| // Option 1: Parse using InputStream, but this requires significant code changes; | |||
| // Option 2: Manually trigger garbage collection, similar to how it's done in Dubbo for large inputs. | |||
| String resp = EntityUtils.toString(response.getEntity(), StandardCharsets.UTF_8); | |||
| if (StringUtils.hasText(resp)) { | |||
| if (!StringUtils.hasText(resp)) { | |||
| log.info("http response entity is empty, status: {}.", statusCode); | |||
There was a problem hiding this comment.
When resp is empty, should we return directly without executing the subsequent logic?
There was a problem hiding this comment.
some http request may not has response data themselves, but still need to be processed.
tomsun28
approved these changes
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
We should log the information only when the
respdoes not include text.It appears that the condition used to check the response is incorrect.
Checklist