Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[collector] fix the wrong condition for checking the response #2067

Merged
merged 2 commits into from
Jun 15, 2024
Merged

[collector] fix the wrong condition for checking the response #2067

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
88ce6a7
[collector] fix the wrong condition for checking the response
ileonli Jun 5, 2024
e584100
Merge branch 'master' into fix-bug-wrong-condition
tomsun28 Jun 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion collector/src/main/java/org/apache/hertzbeat/collector/collect/http/HttpCollectImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ public void collect(CollectRep.MetricsData.Builder builder,
// Option 1: Parse using InputStream, but this requires significant code changes;
// Option 2: Manually trigger garbage collection, similar to how it's done in Dubbo for large inputs.
String resp = EntityUtils.toString(response.getEntity(), StandardCharsets.UTF_8);
if (StringUtils.hasText(resp)) {
if (!StringUtils.hasText(resp)) {
log.info("http response entity is empty, status: {}.", statusCode);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When resp is empty, should we return directly without executing the subsequent logic?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some http request may not has response data themselves, but still need to be processed.

}
Long responseTime = System.currentTimeMillis() - startTime;
Expand Down
Loading