Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add support_pushdown in table trait #1150

Merged
merged 8 commits into from
Aug 15, 2023
Merged

refactor: add support_pushdown in table trait #1150

merged 8 commits into from
Aug 15, 2023

Conversation

jiacai2050
Copy link
Contributor

@jiacai2050 jiacai2050 commented Aug 14, 2023 •
edited
Loading

Rationale

Followup PR of #1126, remove hard code condition check .

Detailed Changes

  • Add support_pushdown
  • Replace unique_keys with is_unique_column to avoid unnecessary Vec allocate.
  • Remove old memory table pushdown tests, all memory table shouldn't support pushdown. Pushdown check is ensured in integration_tests/cases/common/dml/issue-341.sql

Test Plan

Existing tests

ShiKaiWi
ShiKaiWi reviewed Aug 14, 2023
View reviewed changes
common_types/src/schema.rs Outdated Show resolved Hide resolved
common_types/src/schema.rs Outdated Show resolved Hide resolved
table_engine/src/table.rs Outdated Show resolved Hide resolved
@jiacai2050 jiacai2050 mentioned this pull request Aug 15, 2023
Open
ShiKaiWi
ShiKaiWi reviewed Aug 15, 2023
View reviewed changes
table_engine/src/table.rs Outdated Show resolved Hide resolved
@jiacai2050 @ShiKaiWi
Update table_engine/src/table.rs
8e0a0c3 
Co-authored-by: WEI Xikai <ShiKaiWi@users.noreply.github.com>
ShiKaiWi
ShiKaiWi approved these changes Aug 15, 2023
View reviewed changes
Copy link
Member

@ShiKaiWi ShiKaiWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiacai2050 jiacai2050 merged commit 1104866 into apache:main Aug 15, 2023
5 checks passed
@jiacai2050 jiacai2050 deleted the refactor-pushdown branch August 15, 2023 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShiKaiWi ShiKaiWi ShiKaiWi approved these changes

@Rachelint Rachelint Awaiting requested review from Rachelint

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiacai2050 @ShiKaiWi