-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: don't allow create table which failed when open #743
Conversation
Codecov Report
@@ Coverage Diff @@
## main #743 +/- ##
==========================================
+ Coverage 68.43% 68.45% +0.02%
==========================================
Files 294 292 -2
Lines 45712 45355 -357
==========================================
- Hits 31284 31050 -234
+ Misses 14428 14305 -123
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Co-authored-by: chunshao.rcs <worcsrcsgg@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* feat: don't allow create table which failed when open * Update analytic_engine/src/instance/engine.rs Co-authored-by: chunshao.rcs <worcsrcsgg@163.com> * fix CR --------- Co-authored-by: chunshao.rcs <worcsrcsgg@163.com>
Which issue does this PR close?
Closes #
Rationale for this change
Followup PR of #722
When table open failed when recovery, we should prevent user from creating table with same name, otherwise schema maybe wong, and seq will be reset to 0.
What changes are included in this PR?
Are there any user-facing changes?
No
How does this change test
CI, but I don't test this corner case since I don't know how to mock recovery failure of one table.