[HUDI-3743] Support DELETE_PARTITION for metadata table #5169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codope
force-pushed
the
metadata-delete-partition
branch
from
f13c723 to
25b886d
Compare
...park-client/src/main/java/org/apache/hudi/metadata/SparkHoodieBackedTableMetadataWriter.java
Show resolved
Hide resolved
...park-client/src/main/java/org/apache/hudi/metadata/SparkHoodieBackedTableMetadataWriter.java
Outdated
Show resolved
Hide resolved
|
LGTM， In addition, I want to wait for #4489 to merge in and then merge this? |
XuQianJin-Stars
approved these changes
Mar 30, 2022
Got it. I'll wait for that to land first. |
codope
added
the
priority:critical
nsivabalan
added
priority:blocker
and removed
priority:critical
nsivabalan
reviewed
Mar 30, 2022
...park-client/src/main/java/org/apache/hudi/metadata/SparkHoodieBackedTableMetadataWriter.java
Outdated
Show resolved
Hide resolved
...ent/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataWriter.java
Outdated
Show resolved
Hide resolved
...i-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java
Outdated
Show resolved
Hide resolved
...i-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedMetadata.java
Show resolved
Hide resolved
codope
force-pushed
the
metadata-delete-partition
branch
from
0912c87 to
dfe7b9c
Compare
codope
commented
Mar 31, 2022
...source/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTableDropPartition.scala
Outdated
Show resolved
Hide resolved
Minor checkstyle fix
codope
force-pushed
the
metadata-delete-partition
branch
from
338c69a to
6c89a72
Compare
nsivabalan
reviewed
Aug 29, 2022
| try { | ||
| // Because the partition of BaseTableMetadata has been deleted, | ||
| // all partition information can only be obtained from FileSystemBackedTableMetadata. | ||
| FileSystemBackedTableMetadata fsBackedTableMetadata = new FileSystemBackedTableMetadata(context, |
4 tasks
nsivabalan
added a commit
that referenced
this pull request
Apr 21, 2023
#8384) - Looks like when we fallback to full partition cleaning in clean planner, we do FS based listing even though metadata is enabled. It was added in #5169 mainly due to how delete_partition was designed back then. Later delete_partition logic evolved and now we should be good to make this metadata based if applicable.
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
apache#8384) - Looks like when we fallback to full partition cleaning in clean planner, we do FS based listing even though metadata is enabled. It was added in apache#5169 mainly due to how delete_partition was designed back then. Later delete_partition logic evolved and now we should be good to make this metadata based if applicable.
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
apache#8384) - Looks like when we fallback to full partition cleaning in clean planner, we do FS based listing even though metadata is enabled. It was added in apache#5169 mainly due to how delete_partition was designed back then. Later delete_partition logic evolved and now we should be good to make this metadata based if applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
In order to drop any metadata partition (index), we can reuse the DELETE_PARTITION operation in metadata table. Subsequent to this, we can support drop index (with table config update) for async metadata indexer.
Brief change log
HoodieTableMetadataWriterVerify this pull request
Added a unit test in TestHoodieBackedMetadata, which creates multiple metadata partitions and then drops one. Asserted that there are no file slice from the dropped partition.
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.