[HUDI-6039] Fixing FS based listing for full cleaning in clean Planner #8384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
force-pushed
the
clean_planner_revert_fs_based_listing
branch
from
e0515dc to
98414ab
Compare
|
cc @umehrot2 |
nsivabalan
force-pushed
the
clean_planner_revert_fs_based_listing
branch
from
5f94019 to
f8aa7b9
Compare
codope
reviewed
Apr 13, 2023
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java
Outdated
Show resolved
Hide resolved
bvaradar
reviewed
Apr 18, 2023
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java
Outdated
Show resolved
Hide resolved
...source/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestAlterTableDropPartition.scala
Show resolved
Hide resolved
nsivabalan
force-pushed
the
clean_planner_revert_fs_based_listing
branch
from
9d90f97 to
08ec5be
Compare
bvaradar
approved these changes
Apr 19, 2023
nsivabalan
force-pushed
the
clean_planner_revert_fs_based_listing
branch
from
27c25af to
4064bbe
Compare
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
apache#8384) - Looks like when we fallback to full partition cleaning in clean planner, we do FS based listing even though metadata is enabled. It was added in apache#5169 mainly due to how delete_partition was designed back then. Later delete_partition logic evolved and now we should be good to make this metadata based if applicable.
yihua
pushed a commit
to yihua/hudi
that referenced
this pull request
May 15, 2023
apache#8384) - Looks like when we fallback to full partition cleaning in clean planner, we do FS based listing even though metadata is enabled. It was added in apache#5169 mainly due to how delete_partition was designed back then. Later delete_partition logic evolved and now we should be good to make this metadata based if applicable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Looks like when we fallback to full partition cleaning in clean planner, we do FS based listing even though metadata is enabled. It was added in #5169 mainly due to how delete_partition was designed back then. Later delete_partition logic evolved and now we should be good to make this metadata based if applicable.
Impact
Will improve clean planning latency for large tables.
Risk level (write none, low medium or high below)
low.
Documentation Update
N/A
Contributor's checklist